You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/01 22:17:26 UTC
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request
#4657: [TE] Clean up legacy detection related classes;
update ADContentFormatterContext
akshayrai commented on a change in pull request #4657: [TE] Clean up legacy detection related classes; update ADContentFormatterContext
URL: https://github.com/apache/incubator-pinot/pull/4657#discussion_r330301121
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java
##########
@@ -485,6 +491,12 @@ public MergedAnomalyResultDTO convertMergedAnomalyBean2DTO(MergedAnomalyResultBe
mergedAnomalyResultDTO.setFunction(anomalyFunctionDTO);
}
+ if (mergedAnomalyResultBean.getDetectionConfigId() != null) {
Review comment:
Good point
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org