You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sadpandajoe (via GitHub)" <gi...@apache.org> on 2026/10/21 19:25:16 UTC
[PR] fix(theme): restore the 12px tooltip font size dropped by the theming overhaul [superset]
sadpandajoe opened a new pull request, #45581:
URL: https://github.com/apache/superset/pull/45581
### SUMMARY
Superset tooltips rendered at the small font size (12px, line-height 1.6) from #11737 (2020) onward: first as an inline `overlayStyle` on the Tooltip wrapper, then as the `components.Tooltip` token override that #31182 moved into the Ant Design v5 theme config in `superset-frontend/src/theme/index.ts`. The theming overhaul #31590 (dd129fa403) deleted that file wholesale and nothing re-seeded the override, so from 6.0.0 every tooltip falls back to Ant Design's global `fontSize` of 14px. The dashboard favorite-star and published-status tooltips reported in #38726 are the visible symptom; the regression is app-wide.
This change seeds `components.Tooltip = { fontSize: 12, lineHeight: 1.6 }` in `_THEME_DEFAULT_BASE` in `superset/config.py`, which is the one place built-in theme tokens live (the frontend `Theme` class seeds nothing itself). `_THEME_DARK_BASE` spreads the default base, so dark mode inherits the override, and the existing deep merge in `get_theme_bootstrap_data` keeps it for deployments that override only part of `THEME_DEFAULT`. Antd v6 emits this as a tooltip-scoped `--ant-font-size: 12px` CSS variable, so no wrapper or inline style is needed. A unit test asserts both shipped themes carry the override.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screenshots could not be captured: the branch preview environment failed to start, so there are no before/after captures for this PR.
### TESTING INSTRUCTIONS
1. Start Superset with the default configuration and open any dashboard.
2. Hover the favorite star next to the dashboard title, and the Draft / Published pill. The tooltip text should be noticeably smaller than the dashboard body text (12px rather than 14px).
3. Switch to dark mode from the user menu and hover the same icons; the tooltip stays at the small size.
4. In `superset_config.py`, set a partial override such as `THEME_DEFAULT = {"token": {"colorPrimary": "#ff0000"}}` and restart. The primary color changes and the tooltips remain small, confirming the override survives the deep merge.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #38726
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Notes:
- The frontend's built-in fallback theme (used only when the bootstrap payload carries no theme at all) has no Tooltip override, so tooltips there would still render at Ant Design's 14px; the dashboard path reported in the issue is unaffected.
- The new test asserts the shipped config values rather than the rendered tooltip font size.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(theme): restore the 12px tooltip font size dropped by the theming overhaul [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45581:
URL: https://github.com/apache/superset/pull/45581#issuecomment-6352026179
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/39835090039) for [9a1cdc7](https://github.com/apache/superset/commit/9a1cdc7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(theme): restore the 12px tooltip font size dropped by the theming overhaul [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45581:
URL: https://github.com/apache/superset/pull/45581#issuecomment-6324755932
## CodeAnt PR Risk: Low Risk
- The PR appears safe to merge; no actionable issues were identified in the review.
**Assessed commit:** `78df94537da1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(theme): restore the 12px tooltip font size dropped by the theming overhaul [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45581:
URL: https://github.com/apache/superset/pull/45581#issuecomment-6328440274
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/39679842967) for [78df945](https://github.com/apache/superset/commit/78df945)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(theme): restore the 12px tooltip font size dropped by the theming overhaul [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45581:
URL: https://github.com/apache/superset/pull/45581#issuecomment-6325066362
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45581?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.17%. Comparing base ([`b7bfbd3`](https://app.codecov.io/gh/apache/superset/commit/b7bfbd365e6ee63934f59d6284afb296e07f7a24?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`78df945`](https://app.codecov.io/gh/apache/superset/commit/78df94537da12797666e5c7f60485932d7af4646?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45581 +/- ##
===========================================
+ Coverage 65.44% 81.17% +15.73%
===========================================
Files 3056 3056
Lines 201163 201163
Branches 47040 47040
===========================================
+ Hits 131647 163295 +31648
+ Misses 66556 34435 -32121
- Partials 2960 3433 +473
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.91% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.64% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.05% <ø> (+29.00%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45581/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.58% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45581?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org