You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/07 05:18:39 UTC
[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #4225: [ISSUE #3949] Support gRPC protocol
aaron-ai commented on code in PR #4225:
URL: https://github.com/apache/rocketmq/pull/4225#discussion_r861426140
##########
broker/src/main/java/org/apache/rocketmq/broker/client/ProducerChangeListener.java:
##########
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.broker.client;
+
+public interface ProducerChangeListener {
Review Comment:
Add more comments here.
##########
acl/src/main/java/org/apache/rocketmq/acl/common/AuthorizationHeader.java:
##########
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.acl.common;
+
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.commons.codec.binary.Hex;
+
+public class AuthorizationHeader {
+ private static final String HEADER_SEPARATOR = " ";
+ private static final String CREDENTIALS_SEPARATOR = "/";
+ private static final int AUTH_HEADER_KV_LENGTH = 2;
+ private static final int CREDENTIALS_LENGTH = 3;
+ private static final String CREDENTIAL = "Credential";
+ private static final String SIGNED_HEADERS = "SignedHeaders";
+ private static final String SIGNATURE = "Signature";
+ private String method;
+ private String accessKey;
+ private String regionId;
+ private String channelKey;
+ private String[] signedHeaders;
+ private String signature;
+
+ /**
+ * Parse authorization from gRPC header.
+ *
+ * @param header gRPC header string.
+ * @throws Exception exception.
+ */
+ public AuthorizationHeader(String header) throws DecoderException {
+ String[] result = header.split(HEADER_SEPARATOR, 2);
+ if (result.length != 2) {
+ throw new DecoderException("authorization header is incorrect");
+ }
+ this.method = result[0];
+ String[] keyValues = result[1].split(",");
+ for (String keyValue : keyValues) {
+ String[] kv = keyValue.trim().split("=", 2);
+ int kvLength = kv.length;
+ if (kv.length != AUTH_HEADER_KV_LENGTH) {
+ throw new DecoderException("authorization keyValues length is incorrect, actual length=" + kvLength);
+ }
+ String authItem = kv[0];
+ if (CREDENTIAL.equals(authItem)) {
+ String[] credential = kv[1].split(CREDENTIALS_SEPARATOR);
+ int credentialActualLength = credential.length;
+ if (credentialActualLength < CREDENTIALS_LENGTH) {
+ throw new DecoderException("authorization credential length is incorrect, actual length=" + credentialActualLength);
+ }
+ this.accessKey = credential[0];
+ this.regionId = credential[1];
+ this.channelKey = credential[2];
+ continue;
+ }
+ if (SIGNED_HEADERS.equals(authItem)) {
+ this.signedHeaders = kv[1].split(";");
+ continue;
+ }
+ if (SIGNATURE.equals(authItem)) {
+ this.signature = this.hexToBase64(kv[1]);
+ }
+ }
+ }
+
+ public String hexToBase64(String input) throws DecoderException {
+ byte[] bytes = Hex.decodeHex(input);
+ return Base64.encodeBase64String(bytes);
+ }
+
+ public String getMethod() {
+ return this.method;
+ }
+
+ public String getAccessKey() {
+ return this.accessKey;
+ }
+
+ public String getRegionId() {
+ return this.regionId;
+ }
+
+ public String getChannelKey() {
+ return this.channelKey;
+ }
+
+ public String[] getSignedHeaders() {
+ return this.signedHeaders;
+ }
+
+ public String getSignature() {
+ return this.signature;
+ }
+
+ public void setMethod(final String method) {
+ this.method = method;
+ }
+
+ public void setAccessKey(final String accessKey) {
+ this.accessKey = accessKey;
+ }
+
+ public void setRegionId(final String regionId) {
+ this.regionId = regionId;
+ }
+
+ public void setChannelKey(final String channelKey) {
+ this.channelKey = channelKey;
+ }
+
+ public void setSignedHeaders(final String[] signedHeaders) {
+ this.signedHeaders = signedHeaders;
+ }
+
+ public void setSignature(final String signature) {
+ this.signature = signature;
+ }
+
+ @java.lang.Override
Review Comment:
use `@Override` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org