You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/06 07:08:48 UTC
[GitHub] [skywalking-client-js] Fine0830 opened a new pull request, #79: fix: update fmp metric
Fine0830 opened a new pull request, #79:
URL: https://github.com/apache/skywalking-client-js/pull/79
Fixes fmp metric.
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#discussion_r843586873
##########
src/trace/type.d.ts:
##########
@@ -28,8 +28,8 @@ export interface SpanFields {
startTime: number;
endTime: number;
spanId: number;
- spanLayer: number;
- spanType: number;
+ spanLayer: string;
+ spanType: string;
Review Comment:
Are these working for the HTTP span receiver? FYI @arugal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] Fine0830 commented on a diff in pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#discussion_r843597693
##########
src/trace/type.d.ts:
##########
@@ -28,8 +28,8 @@ export interface SpanFields {
startTime: number;
endTime: number;
spanId: number;
- spanLayer: number;
- spanType: number;
+ spanLayer: string;
+ spanType: string;
Review Comment:
> Are these working for the HTTP span receiver? FYI @arugal
Yes, I have checked the protocol https://github.com/apache/skywalking/blob/master/docs/en/protocols/Trace-Data-Protocol-v3.md. And I found the mistake from https://github.com/apache/skywalking-client-js/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] arugal commented on pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
arugal commented on PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#issuecomment-1089949242
The E2E failed. Please recheck @Fine0830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#issuecomment-1089909310
I think there are 3 other PRs not added into changelogs, https://github.com/apache/skywalking-client-js/milestone/8?closed=1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng merged pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#discussion_r843610453
##########
CHANGES.md:
##########
@@ -1,5 +1,13 @@
# Changes
+## 0.8.0
+
+1. Fix fmp metric.
+2. Add e2e tese based on skywaling-infra-e2e.
+3. Update metric and events.
+4. Add span layers and types.
+
Review Comment:
```suggestion
5. Remove ServiceTag by following SkyWalking v9 new layer model.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on a diff in pull request #79: fix: update fmp metric
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #79:
URL: https://github.com/apache/skywalking-client-js/pull/79#discussion_r843557773
##########
README.md:
##########
@@ -8,6 +8,7 @@ Apache SkyWalking Client JS
- Lightweight
- Make browser as a start of whole distributed tracing
+NOTICE, SkyWalking Client JS 0.8.0 and later versions use SkyWalking v9.
Review Comment:
```suggestion
NOTICE, SkyWalking Client JS 0.8.0 and later versions require SkyWalking v9.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org