You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/29 06:41:11 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #1320: net/sockopt: change the socket option style from Linux to BSD
anchao opened a new pull request #1320:
URL: https://github.com/apache/incubator-nuttx/pull/1320
## Summary
net/sockopt: change the socket option style from Linux to BSD
```
Linux Programmer's Manual
...
IP(7)
...
NOTES
...
Using the SOL_IP socket options level isn't portable;
BSD-based stacks use the IPPROTO_IP level.
```
## Impact
https://github.com/apache/incubator-nuttx/pull/1291
https://github.com/apache/incubator-nuttx-apps/pull/311
## Testing
CI check is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #1320: net/sockopt: change the socket option style from Linux to BSD
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1320:
URL: https://github.com/apache/incubator-nuttx/pull/1320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #1320: net/sockopt: change the socket option style from Linux to BSD
Posted by GitBox <gi...@apache.org>.
anchao commented on pull request #1320:
URL: https://github.com/apache/incubator-nuttx/pull/1320#issuecomment-650974468
Build break Depends on https://github.com/apache/incubator-nuttx/pull/1291
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1320: net/sockopt: change the socket option style from Linux to BSD
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1320:
URL: https://github.com/apache/incubator-nuttx/pull/1320#issuecomment-652064673
You are right!
More info:
https://gitlab.com/FFTEAM/oscam/commit/77fa61d900521bc01a6f19198da7796355635542
https://serverfault.com/questions/239393/how-do-i-get-the-solaris-8-patch-to-fix-the-missing-sol-tcp-in-usr-include-sys
This modification will not impact Linux portability because we have things like this defined already:
#define SOL_TCP IPPROTO_TCP
So I'll apply! Thank you Anchao!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org