You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 18:07:17 UTC

[GitHub] [airflow] ashb commented on pull request #13984: Fixed reading from zip package to default to text.

ashb commented on pull request #13984:
URL: https://github.com/apache/airflow/pull/13984#issuecomment-770253554


   Speaking of the tests: we are testing the implementation which is fragile.
   
   If possible we should instead test that when reading from it we get strings, not bytes (and mock as little as possible - we already have actual zip files in the tests for for this purpose)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org