[GitHub] [iceberg] rdblue commented on a diff in pull request #5984: Core, API: Support incremental scanning with branch

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5984:
URL: https://github.com/apache/iceberg/pull/5984#discussion_r1001951831


##########
api/src/test/java/org/apache/iceberg/AssertHelpers.java:
##########
@@ -48,6 +48,22 @@ public static void assertThrows(
     }
   }
 
+  /**
+   * A convenience method to avoid a large number of @Test(expected=...) tests
+   *
+   * @param expected An Exception class that the Runnable should throw
+   * @param containedInMessage A String that should be contained by the thrown exception's message
+   * @param callable A Callable that is expected to throw the exception
+   */
+  public static void assertThrows(

Review Comment:
   @hililiwei, what is the purpose of this new method? Just not adding context? Context is a best practice, which is why we require it by not adding helpers that drop it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org