You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "behappy1234 (via GitHub)" <gi...@apache.org> on 2023/08/21 02:59:01 UTC
[GitHub] [nuttx] behappy1234 opened a new pull request, #10318: Cordic api modify
behappy1234 opened a new pull request, #10318:
URL: https://github.com/apache/nuttx/pull/10318
Sorry for I wrong closed the PR, and I can not reopen it.
<img width="1096" alt="image" src="https://github.com/apache/nuttx/assets/109731027/7de4fefc-101c-4fae-8233-34809d3ec43f">
https://github.com/apache/nuttx/pull/10282
@raiden00pl @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] behappy1234 commented on pull request #10318: Cordic api modify
Posted by "behappy1234 (via GitHub)" <gi...@apache.org>.
behappy1234 commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1687531135
squash the two commits into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] behappy1234 commented on pull request #10318: Cordic api modify
Posted by "behappy1234 (via GitHub)" <gi...@apache.org>.
behappy1234 commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1685749547
> Response from the old PR [#10282 (comment)](https://github.com/apache/nuttx/pull/10282#issuecomment-1685518888)
>
> > Yes, the numerical type for q1.15 is as a default here. I do this, because if I open for MATH_FFT, then math.c is compiled, so cordic.h is included and CONFIG_MATH_CORDIC_USE_Q31 is needed for cordic_num_t to be configed even in this case I don't need to care about cordic. So, CONFIG_MATH_CORDIC_USE_Q31 is "redundant" here, or a default cordic_num_t definition is need. And I remove it as a default one.
>
> If you don't need cordic, then why just not guard all cordic logic with `#ifdef CONFIG_MATH_CORDIC` ? The same applies to the FFT.
understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] behappy1234 commented on pull request #10318: Cordic api modify
Posted by "behappy1234 (via GitHub)" <gi...@apache.org>.
behappy1234 commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1687577261
> please add commit message
Sorry for miss understanding, I have submmit two commits, and the first one is discarded. No more commit message needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10318: Cordic api modify
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1687792496
@raiden00pl could you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl merged pull request #10318: Cordic api modify
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl merged PR #10318:
URL: https://github.com/apache/nuttx/pull/10318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] raiden00pl commented on pull request #10318: Cordic api modify
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1685661345
Response from the old PR https://github.com/apache/nuttx/pull/10282#issuecomment-1685518888
> Yes, the numerical type for q1.15 is as a default here. I do this, because if I open for MATH_FFT, then math.c is compiled, so cordic.h is included and CONFIG_MATH_CORDIC_USE_Q31 is needed for cordic_num_t to be configed even in this case I don't need to care about cordic. So, CONFIG_MATH_CORDIC_USE_Q31 is "redundant" here, or a default cordic_num_t definition is need. And I remove it as a default one.
If you don't need cordic, then why just not guard all cordic logic with `#ifdef CONFIG_MATH_CORDIC` ? The same applies to the FFT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 closed pull request #10318: Cordic api modify
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #10318: Cordic api modify
URL: https://github.com/apache/nuttx/pull/10318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org