You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/28 15:55:00 UTC
[jira] [Commented] (ARTEMIS-1712) [openwire] missing null check
could lead to NPE during TX rollback
[ https://issues.apache.org/jira/browse/ARTEMIS-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380510#comment-16380510 ]
ASF GitHub Bot commented on ARTEMIS-1712:
-----------------------------------------
GitHub user tabish121 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1909
ARTEMIS-1712 Add additional null check in TX rollback handler
Check for AMQSession being null before handling various TX state checks
in order to ensure the correct errors are thrown and TX rollback is
handled properly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1712
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1909.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1909
----
commit 8fc1e00d88fed9419e566d1fb69b46175585e9f1
Author: Timothy Bish <ta...@...>
Date: 2018-02-28T15:46:31Z
ARTEMIS-1712 Add additional null check in TX rollback handler
Check for AMQSession being null before handling various TX state checks
in order to ensure the correct errors are thrown and TX rollback is
handled properly.
----
> [openwire] missing null check could lead to NPE during TX rollback
> ------------------------------------------------------------------
>
> Key: ARTEMIS-1712
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1712
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 2.4.0
> Reporter: Timothy Bish
> Priority: Minor
> Fix For: 2.5.0
>
>
> Code in OpenWireConnection that processes transaction rollback fails to check that the TX provided is not null before trying to extract the session from the protocol data which could lead to an NPE and circumvent all the later checking that tries to handle that case such as a rollback when TX not started case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)