You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lo...@apache.org on 2017/04/28 10:26:11 UTC
svn commit: r1793034 [8/9] - /myfaces/site/publish/tobago/
Modified: myfaces/site/publish/tobago/pmd.html
URL: http://svn.apache.org/viewvc/myfaces/site/publish/tobago/pmd.html?rev=1793034&r1=1793033&r2=1793034&view=diff
==============================================================================
--- myfaces/site/publish/tobago/pmd.html (original)
+++ myfaces/site/publish/tobago/pmd.html Fri Apr 28 10:26:10 2017
@@ -14,7 +14,7 @@
<div class="date">
- Last Published: 08 Feb 2017
+ Last Published: 28 Apr 2017
</div>
<ul>
<li>
@@ -258,7 +258,7 @@
<div class="section">
<h2><a name="PMD_Results"></a>PMD Results</h2>
<p>The following document contains the results of <a class="externalLink"
- href="http://pmd.sourceforge.net/">PMD</a> 5.2.3.</p></div>
+ href="http://pmd.sourceforge.net/">PMD</a> 5.5.1.</p></div>
<div class="section">
<h2><a name="Files"></a>Files</h2>
<div class="section">
@@ -271,40 +271,16 @@
</tr>
<tr class="b">
<td>Parameter 'explicit' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L262">262</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L315">315</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L267">267</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L271">271</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L320">320</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L324">324</a></td>
</tr>
<tr class="b">
<td>Parameter 'name' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L274">274</a></td>
- </tr>
- </table>
- </div>
- <div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentFacets.java"></a>Tobago Core -
- org/apache/myfaces/tobago/component/Facets.java</h3>
- <table border="0" class="bodyTable">
- <tr class="a">
- <th>Violation</th>
- <th>Line</th>
- </tr>
- <tr class="b">
- <td>Document empty constructor</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L50">50</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/Facets.html#L51">51</a></td>
- </tr>
- <tr class="a">
- <td>Parameter 'event' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L54">54</a></td>
- </tr>
- <tr class="b">
- <td>Document empty constructor</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Facets.html#L54">54</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/Facets.html#L55">55</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Attributes.html#L327">327</a></td>
</tr>
</table>
</div>
@@ -331,21 +307,10 @@
<th>Line</th>
</tr>
<tr class="b">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L37">37</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L241">241</a>
- </td>
- </tr>
- <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L47">47</a>–<a
href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L48">48</a></td>
</tr>
- <tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodBindingToMethodExpression.html#L96">96</a>
- </td>
- </tr>
</table>
</div>
<div class="section">
@@ -369,11 +334,6 @@
</td>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/MethodExpressionToMethodBinding.html#L70">70</a>
- </td>
- </tr>
- <tr class="a">
<td>Unnecessary use of fully qualified name 'javax.faces.el.MethodNotFoundException' due to existing
import 'javax.faces.el.MethodNotFoundException'
</td>
@@ -386,37 +346,42 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocomponentSorter.java"></a>Tobago Core -
org/apache/myfaces/tobago/component/Sorter.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Possible God class (WMC=51, ATFD=25, TCC=0.2)</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L20">20</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L259">259</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The class 'Sorter' has a Cyclomatic Complexity of 8 (Highest = 30).</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>The class 'Sorter' has a Standard Cyclomatic Complexity of 6 (Highest = 28).</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>The class 'Sorter' has a Modified Cyclomatic Complexity of 6 (Highest = 28).</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L49">49</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L258">258</a></td>
</tr>
+ <tr class="b">
+ <td>The method 'perform' has a Modified Cyclomatic Complexity of 28.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
+ href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
+ </tr>
<tr class="a">
- <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
+ <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>Avoid really long methods.</td>
+ <td>The method 'perform' has a Standard Cyclomatic Complexity of 28.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
@@ -426,30 +391,25 @@
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="b">
- <td>The method 'perform' has a Cyclomatic Complexity of 30.</td>
+ <td>Avoid really long methods.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
</tr>
<tr class="a">
- <td>The method 'perform' has a Modified Cyclomatic Complexity of 28.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L64">64</a>–<a
- href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L201">201</a></td>
- </tr>
- <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L96">96</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L137">137</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L99">99</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L132">132</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L199">199</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>The method 'getFirstSortableChild' has a Cyclomatic Complexity of 13.</td>
<td><a href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L224">224</a>–<a
href="./xref/org/apache/myfaces/tobago/component/Sorter.html#L249">249</a></td>
@@ -457,100 +417,120 @@
</table>
</div>
<div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoconfigTobagoConfig.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/config/TobagoConfig.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
+ <td>Class contains multiple getInstance methods. Please review.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/config/TobagoConfig.html#L40">40</a>–<a
+ href="./xref/org/apache/myfaces/tobago/config/TobagoConfig.html#L42">42</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagocontextMarkup.java"></a>Tobago Core -
org/apache/myfaces/tobago/context/Markup.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
+ <tr class="b">
+ <td>The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L376">376</a></td>
+ </tr>
<tr class="a">
- <td>The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11).</td>
+ <td>This class has too many methods, consider refactoring it.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L376">376</a></td>
</tr>
<tr class="b">
- <td>The class 'Markup' has a Standard Cyclomatic Complexity of 5 (Highest = 10).</td>
+ <td>The class 'Markup' has a Cyclomatic Complexity of 5 (Highest = 11).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L376">376</a></td>
</tr>
<tr class="a">
<td>The class 'Markup' has a Modified Cyclomatic Complexity of 5 (Highest = 10).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L376">376</a></td>
</tr>
<tr class="b">
- <td>This class has too many methods, consider refactoring it.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L57">57</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L369">369</a></td>
+ <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L122">122</a></td>
</tr>
<tr class="a">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L115">115</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L132">132</a></td>
</tr>
<tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L125">125</a></td>
+ <td>Avoid if (x != y) ..; else ..;</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L192">192</a></td>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L185">185</a></td>
+ <td>Avoid unnecessary if..then..else statements when returning booleans</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L195">195</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L197">197</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L197">197</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L204">204</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L198">198</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L205">205</a></td>
</tr>
<tr class="b">
<td>Use equals() to compare object references.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L221">221</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L228">228</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L224">224</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L235">235</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L231">231</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L242">242</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L265">265</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L274">274</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L272">272</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L281">281</a></td>
</tr>
<tr class="a">
- <td>The method 'contains' has a Standard Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
+ <td>The method 'contains' has a Modified Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L333">333</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L363">363</a></td>
</tr>
<tr class="b">
- <td>The method 'contains' has a Modified Cyclomatic Complexity of 10.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
+ <td>The method 'contains' has a Cyclomatic Complexity of 11.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L333">333</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L363">363</a></td>
</tr>
<tr class="a">
- <td>The method 'contains' has a Cyclomatic Complexity of 11.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L326">326</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L356">356</a></td>
+ <td>The method 'contains' has a Standard Cyclomatic Complexity of 10.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L333">333</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L363">363</a></td>
</tr>
<tr class="b">
<td>Use equals() to compare object references.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L327">327</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L334">334</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L333">333</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L355">355</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L340">340</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L362">362</a></td>
</tr>
<tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L334">334</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L343">343</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L341">341</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L350">350</a></td>
</tr>
<tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L345">345</a>–<a
- href="./xref/org/apache/myfaces/tobago/context/Markup.html#L354">354</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/Markup.html#L352">352</a>–<a
+ href="./xref/org/apache/myfaces/tobago/context/Markup.html#L361">361</a></td>
</tr>
</table>
</div>
@@ -584,12 +564,12 @@
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L303">303</a></td>
</tr>
<tr class="b">
- <td>The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td>The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 12).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L303">303</a></td>
</tr>
<tr class="a">
- <td>The class 'ThemeImpl' has a Cyclomatic Complexity of 2 (Highest = 12).</td>
+ <td>The class 'ThemeImpl' has a Standard Cyclomatic Complexity of 2 (Highest = 12).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L303">303</a></td>
</tr>
@@ -620,7 +600,7 @@
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L148">148</a></td>
</tr>
<tr class="a">
- <td>The method 'toString' has a Cyclomatic Complexity of 12.</td>
+ <td>The method 'toString' has a Standard Cyclomatic Complexity of 12.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L262">262</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L302">302</a></td>
</tr>
@@ -630,7 +610,7 @@
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L302">302</a></td>
</tr>
<tr class="a">
- <td>The method 'toString' has a Standard Cyclomatic Complexity of 12.</td>
+ <td>The method 'toString' has a Cyclomatic Complexity of 12.</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L262">262</a>–<a
href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L302">302</a></td>
</tr>
@@ -662,11 +642,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L270">270</a></td>
</tr>
<tr class="b">
- <td>Local variable 's' could be declared final</td>
+ <td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L275">275</a></td>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
+ <td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L275">275</a></td>
</tr>
<tr class="b">
@@ -674,11 +654,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L276">276</a></td>
</tr>
<tr class="a">
- <td>Local variable 's' could be declared final</td>
+ <td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L280">280</a></td>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
+ <td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L280">280</a></td>
</tr>
<tr class="a">
@@ -686,11 +666,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L281">281</a></td>
</tr>
<tr class="b">
- <td>Avoid if (x != y) ..; else ..;</td>
+ <td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L285">285</a></td>
</tr>
<tr class="a">
- <td>Local variable 's' could be declared final</td>
+ <td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L285">285</a></td>
</tr>
<tr class="b">
@@ -698,11 +678,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L286">286</a></td>
</tr>
<tr class="a">
- <td>Avoid if (x != y) ..; else ..;</td>
+ <td>Local variable 's' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L290">290</a></td>
</tr>
<tr class="b">
- <td>Local variable 's' could be declared final</td>
+ <td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/ThemeImpl.html#L290">290</a></td>
</tr>
<tr class="a">
@@ -811,7 +791,7 @@
href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L135">135</a></td>
</tr>
<tr class="a">
- <td>Parameter 'loader' is not assigned and could be declared final</td>
+ <td>Parameter 'format' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L101">101</a></td>
</tr>
<tr class="b">
@@ -819,15 +799,15 @@
<td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L101">101</a></td>
</tr>
<tr class="a">
- <td>Parameter 'format' is not assigned and could be declared final</td>
+ <td>Parameter 'locale' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L101">101</a></td>
</tr>
<tr class="b">
- <td>Parameter 'reload' is not assigned and could be declared final</td>
+ <td>Parameter 'loader' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L101">101</a></td>
</tr>
<tr class="a">
- <td>Parameter 'locale' is not assigned and could be declared final</td>
+ <td>Parameter 'reload' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/TobagoBundle.html#L101">101</a></td>
</tr>
<tr class="b">
@@ -948,7 +928,7 @@
<th>Line</th>
</tr>
<tr class="b">
- <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
+ <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
@@ -958,33 +938,33 @@
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="b">
- <td>The class 'UserAgent' has a Modified Cyclomatic Complexity of 3 (Highest = 19).</td>
+ <td>The class 'UserAgent' has a Cyclomatic Complexity of 3 (Highest = 20).</td>
<td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L33">33</a>–<a
href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L390">390</a></td>
</tr>
<tr class="a">
<td>The String literal "msie" appears 12 times in this file; the first occurrence is on line
- 43
+ 39
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L43">43</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L39">39</a></td>
</tr>
<tr class="b">
<td>The String literal "opera" appears 4 times in this file; the first occurrence is on line
- 107
+ 103
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L107">107</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L103">103</a></td>
</tr>
<tr class="a">
<td>The String literal "mozilla" appears 4 times in this file; the first occurrence is on line
- 131
+ 127
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L131">131</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L127">127</a></td>
</tr>
<tr class="b">
<td>The String literal "gecko" appears 5 times in this file; the first occurrence is on line
- 154
+ 150
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L154">154</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/context/UserAgent.html#L150">150</a></td>
</tr>
<tr class="a">
<td>The method 'getInstance' has a Standard Cyclomatic Complexity of 19.</td>
@@ -1061,52 +1041,48 @@
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L43">43</a></td>
</tr>
<tr class="a">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
- </tr>
- <tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Parameter 'params' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L49">49</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'o' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L55">55</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Local variable 'that' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L63">63</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L65">65</a></td>
</tr>
- <tr class="a">
- <td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L85">85</a></td>
- </tr>
<tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L85">85</a></td>
</tr>
<tr class="a">
<td>Parameter 'state' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
</tr>
+ <tr class="b">
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/el/ConstantMethodExpression.html#L90">90</a></td>
+ </tr>
</table>
</div>
<div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoelUserWrapper.java"></a>Tobago Core -
org/apache/myfaces/tobago/el/UserWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'roles' could be made final; it is only initialized in the declaration or constructor.
</td>
<td><a href="./xref/org/apache/myfaces/tobago/el/UserWrapper.html#L35">35</a></td>
@@ -1117,23 +1093,23 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventCollapsibleActionListener.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/CollapsibleActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L69">69</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'state' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L74">74</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L74">74</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'transientFlag' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/CollapsibleActionListener.html#L84">84</a></td>
</tr>
@@ -1143,11 +1119,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventFacesEventWrapper.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/FacesEventWrapper.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'wrappedFacesEvent' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1159,16 +1135,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionStateChangeListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionStateChangeListener.html#L36">36</a></td>
@@ -1179,16 +1155,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTabChangeListener.java"></a>Tobago Core
- org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L33">33</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTabChangeListener.html#L36">36</a></td>
@@ -1199,22 +1175,22 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeExpansionListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L34">34</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L36">36</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L37">37</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid unused private methods such as 'elContext()'.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeExpansionListener.html#L48">48</a>
</td>
@@ -1225,22 +1201,22 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventMethodExpressionTreeSelectedListener.java"></a>Tobago
Core - org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid using redundant field initializer for 'isTransient'</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L33">33</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L35">35</a>–<a
href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L36">36</a>
</td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Avoid unused private methods such as 'elContext()'.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/MethodExpressionTreeSelectedListener.html#L47">47</a>
</td>
@@ -1251,11 +1227,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventPageActionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/PageActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Private field 'action' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1267,16 +1243,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventResetInputActionListener.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/ResetInputActionListener.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Document empty constructor</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L34">34</a>–<a
href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L35">35</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
<td><a href="./xref/org/apache/myfaces/tobago/event/ResetInputActionListener.html#L37">37</a></td>
</tr>
@@ -1286,11 +1262,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventSortActionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/SortActionEvent.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Private field 'column' could be made final; it is only initialized in the declaration or
constructor.
</td>
@@ -1299,6 +1275,24 @@
</table>
</div>
<div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTabChangeEvent.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/event/TabChangeEvent.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
+ <td>Overridable method 'setOldState' called during object construction</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TabChangeEvent.html#L45">45</a></td>
+ </tr>
+ <tr class="a">
+ <td>Overridable method 'setNewState' called during object construction</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/event/TabChangeEvent.html#L46">46</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
<h3><a name="Tobago_Core_-_orgapachemyfacestobagoeventTreeExpansionEvent.java"></a>Tobago Core -
org/apache/myfaces/tobago/event/TreeExpansionEvent.java</h3>
<table border="0" class="bodyTable">
@@ -1422,17 +1416,17 @@
<th>Line</th>
</tr>
<tr class="a">
- <td>Possible God class (WMC=77, ATFD=82, TCC=0.027777777777777776)</td>
+ <td>A high number of imports can indicate a high degree of coupling within an object.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L356">356</a></td>
</tr>
<tr class="b">
- <td>A high number of imports can indicate a high degree of coupling within an object.</td>
+ <td>Possible God class (WMC=77, ATFD=82, TCC=0.027777777777777776)</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L20">20</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L356">356</a></td>
</tr>
<tr class="a">
- <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 50).</td>
+ <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 57).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L356">356</a></td>
</tr>
@@ -1442,17 +1436,17 @@
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L356">356</a></td>
</tr>
<tr class="a">
- <td>The class 'AttributeHandler' has a Cyclomatic Complexity of 7 (Highest = 57).</td>
+ <td>The class 'AttributeHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 50).</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L56">56</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L356">356</a></td>
</tr>
<tr class="b">
- <td>Avoid really long methods.</td>
+ <td>The method 'apply' has a Cyclomatic Complexity of 57.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L273">273</a></td>
</tr>
<tr class="a">
- <td>The method 'apply' has a Standard Cyclomatic Complexity of 50.</td>
+ <td>Avoid really long methods.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L273">273</a></td>
</tr>
@@ -1462,7 +1456,7 @@
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L273">273</a></td>
</tr>
<tr class="a">
- <td>The method 'apply' has a Cyclomatic Complexity of 57.</td>
+ <td>The method 'apply' has a Standard Cyclomatic Complexity of 50.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L74">74</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/AttributeHandler.html#L273">273</a></td>
</tr>
@@ -1543,35 +1537,35 @@
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L81">81</a></td>
</tr>
<tr class="b">
- <td>Parameter 'parent' is not assigned and could be declared final</td>
+ <td>Parameter 'ctx' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L86">86</a></td>
</tr>
<tr class="a">
- <td>Parameter 'ctx' is not assigned and could be declared final</td>
+ <td>Parameter 'parent' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L86">86</a></td>
</tr>
<tr class="b">
- <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td>Parameter 'parent' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L136">136</a></td>
</tr>
<tr class="a">
- <td>Parameter 'parent' is not assigned and could be declared final</td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L136">136</a></td>
</tr>
<tr class="b">
+ <td>Avoid unused local variables such as 'faceletContext'.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L138">138</a></td>
+ </tr>
+ <tr class="a">
<td>Local variable 'faceletContext' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L138">138</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L139">139</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid declaring a variable if it is unreferenced before a possible exit point.</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L138">138</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L139">139</a></td>
</tr>
- <tr class="b">
- <td>Avoid unused local variables such as 'faceletContext'.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L138">138</a></td>
- </tr>
<tr class="a">
<td>Local variable 'cvh' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L142">142</a></td>
@@ -1597,11 +1591,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L174">174</a></td>
</tr>
<tr class="a">
- <td>Parameter 'faceletContext' is not assigned and could be declared final</td>
+ <td>Parameter 'component' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L179">179</a></td>
</tr>
<tr class="b">
- <td>Parameter 'component' is not assigned and could be declared final</td>
+ <td>Parameter 'faceletContext' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/EventHandler.html#L179">179</a></td>
</tr>
<tr class="a">
@@ -1648,7 +1642,7 @@
<th>Line</th>
</tr>
<tr class="b">
- <td>Document empty method</td>
+ <td>Document empty method body</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L57">57</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/FixCharacterEncodingFilter.html#L58">58</a></td>
</tr>
@@ -1663,21 +1657,9 @@
<th>Line</th>
</tr>
<tr class="b">
- <td>Avoid reassigning parameters such as 'path'</td>
- <td><a
- href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L55">55</a>
- </td>
- </tr>
- <tr class="a">
- <td>Avoid reassigning parameters such as 'path'</td>
- <td><a
- href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L55">55</a>
- </td>
- </tr>
- <tr class="b">
<td>This call to String.startsWith can be rewritten using String.charAt(0)</td>
<td><a
- href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L61">61</a>
+ href="./xref/org/apache/myfaces/tobago/facelets/MetaInfResourcesClasspathResourceResolver.html#L64">64</a>
</td>
</tr>
</table>
@@ -1696,7 +1678,7 @@
href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L74">74</a></td>
</tr>
<tr class="a">
- <td>Document empty method</td>
+ <td>Document empty method body</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L114">114</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/Resource.html#L115">115</a></td>
</tr>
@@ -1715,50 +1697,114 @@
<th>Line</th>
</tr>
<tr class="b">
- <td>Document empty method</td>
+ <td>Document empty method body</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L34">34</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L35">35</a></td>
</tr>
<tr class="a">
- <td>Document empty method</td>
+ <td>Document empty method body</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L38">38</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/ScriptHandler.html#L39">39</a></td>
</tr>
</table>
</div>
<div class="section">
- <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSegmentLayoutRule.java"></a>Tobago Core -
- org/apache/myfaces/tobago/facelets/SegmentLayoutRule.java</h3>
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSegmentLayoutConstraintHandler.java"></a>Tobago Core
+ - org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.java</h3>
<table border="0" class="bodyTable">
<tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
<tr class="a">
+ <td>The class 'SegmentLayoutConstraintHandler' has a Standard Cyclomatic Complexity of 10 (Highest =
+ 17).
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L32">32</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L131">131</a></td>
+ </tr>
+ <tr class="b">
+ <td>The class 'SegmentLayoutConstraintHandler' has a Cyclomatic Complexity of 10 (Highest = 17).</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L32">32</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L131">131</a></td>
+ </tr>
+ <tr class="a">
+ <td>The class 'SegmentLayoutConstraintHandler' has a Modified Cyclomatic Complexity of 10 (Highest =
+ 17).
+ </td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L32">32</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L131">131</a></td>
+ </tr>
+ <tr class="b">
+ <td>Parameter 'config' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L43">43</a>
+ </td>
+ </tr>
+ <tr class="a">
+ <td>The method 'apply' has a Cyclomatic Complexity of 17.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L130">130</a></td>
+ </tr>
+ <tr class="b">
+ <td>The method 'apply' has a Modified Cyclomatic Complexity of 17.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L130">130</a></td>
+ </tr>
+ <tr class="a">
+ <td>Parameter 'parent' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>
+ </td>
+ </tr>
+ <tr class="b">
+ <td>Parameter 'faceletContext' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>
+ </td>
+ </tr>
+ <tr class="a">
+ <td>The method 'apply' has a Standard Cyclomatic Complexity of 17.</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L130">130</a></td>
+ </tr>
+ <tr class="b">
+ <td>The method apply() has an NPath complexity of 6561</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L56">56</a>–<a
+ href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutConstraintHandler.html#L130">130</a></td>
+ </tr>
+ </table>
+ </div>
+ <div class="section">
+ <h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSegmentLayoutRule.java"></a>Tobago Core -
+ org/apache/myfaces/tobago/facelets/SegmentLayoutRule.java</h3>
+ <table border="0" class="bodyTable">
+ <tr class="a">
+ <th>Violation</th>
+ <th>Line</th>
+ </tr>
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L39">39</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L53">53</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Local variable 'a' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L40">40</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L41">41</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L43">43</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L44">44</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L46">46</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L47">47</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L49">49</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L50">50</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SegmentLayoutRule.html#L52">52</a></td>
@@ -1769,11 +1815,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSheetStateChangeSourceRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.html#L41">41</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SheetStateChangeSourceRule.html#L43">43</a></td>
@@ -1784,11 +1830,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSortActionSourceRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SortActionSourceRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SortActionSourceRule.html#L42">42</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SortActionSourceRule.html#L44">44</a></td>
@@ -1799,11 +1845,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSpanHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SpanHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Parameter 'parent' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SpanHandler.html#L47">47</a></td>
</tr>
@@ -1813,26 +1859,26 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSuggestMethodRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SuggestMethodRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="a">
+ <tr class="b">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="b">
+ <tr class="a">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L42">42</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L44">44</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L47">47</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L51">51</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L50">50</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L48">48</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/SuggestMethodRule.html#L50">50</a></td>
@@ -1843,11 +1889,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsSupportsMarkupRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/SupportsMarkupRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Local variable 'a' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/SupportsMarkupRule.html#L41">41</a></td>
</tr>
@@ -1857,20 +1903,20 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsTabChangeListenerHandler.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.html#L77">77</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>Deeply nested if..then statements are hard to read</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.html#L79">79</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.html#L81">81</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.html#L83">83</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/TabChangeListenerHandler.html#L88">88</a></td>
@@ -1881,11 +1927,11 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsTabChangeSourceRule.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/TabChangeSourceRule.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>These nested if statements could be combined</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TabChangeSourceRule.html#L38">38</a>–<a
href="./xref/org/apache/myfaces/tobago/facelets/TabChangeSourceRule.html#L40">40</a></td>
@@ -1896,26 +1942,22 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagofaceletsTagMethodExpression.java"></a>Tobago Core -
org/apache/myfaces/tobago/facelets/TagMethodExpression.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TagMethodExpression.html#L64">64</a></td>
</tr>
- <tr class="b">
+ <tr class="a">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TagMethodExpression.html#L66">66</a></td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TagMethodExpression.html#L68">68</a></td>
</tr>
- <tr class="b">
- <td>Consider using varargs for methods or constructors which take an array the last parameter.</td>
- <td><a href="./xref/org/apache/myfaces/tobago/facelets/TagMethodExpression.html#L73">73</a></td>
- </tr>
<tr class="a">
<td>New exception is thrown in catch block, original stack trace may be lost</td>
<td><a href="./xref/org/apache/myfaces/tobago/facelets/TagMethodExpression.html#L77">77</a></td>
@@ -2094,22 +2136,22 @@
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L763">763</a></td>
</tr>
<tr class="a">
- <td>The class 'DeltaStateHelper' has a Cyclomatic Complexity of 4 (Highest = 12).</td>
+ <td>The class 'DeltaStateHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 11).</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L147">147</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L763">763</a></td>
</tr>
<tr class="b">
- <td>This class has too many methods, consider refactoring it.</td>
+ <td>The class 'DeltaStateHelper' has a Cyclomatic Complexity of 4 (Highest = 12).</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L147">147</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L763">763</a></td>
</tr>
<tr class="a">
- <td>The class 'DeltaStateHelper' has a Modified Cyclomatic Complexity of 4 (Highest = 11).</td>
+ <td>The class 'DeltaStateHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 11).</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L147">147</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L763">763</a></td>
</tr>
<tr class="b">
- <td>The class 'DeltaStateHelper' has a Standard Cyclomatic Complexity of 4 (Highest = 11).</td>
+ <td>This class has too many methods, consider refactoring it.</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L147">147</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L763">763</a></td>
</tr>
@@ -2134,11 +2176,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L175">175</a></td>
</tr>
<tr class="a">
- <td>Parameter 'value' is not assigned and could be declared final</td>
+ <td>Parameter 'key' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L203">203</a></td>
</tr>
<tr class="b">
- <td>Parameter 'key' is not assigned and could be declared final</td>
+ <td>Parameter 'value' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L203">203</a></td>
</tr>
<tr class="a">
@@ -2155,11 +2197,11 @@
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L231">231</a></td>
</tr>
<tr class="b">
- <td>Parameter 'defaultValue' is not assigned and could be declared final</td>
+ <td>Parameter 'key' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L239">239</a></td>
</tr>
<tr class="a">
- <td>Parameter 'key' is not assigned and could be declared final</td>
+ <td>Parameter 'defaultValue' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L239">239</a></td>
</tr>
<tr class="b">
@@ -2184,15 +2226,15 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L257">257</a></td>
</tr>
<tr class="a">
- <td>Parameter 'mapKey' is not assigned and could be declared final</td>
+ <td>Parameter 'value' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L281">281</a></td>
</tr>
<tr class="b">
- <td>Parameter 'value' is not assigned and could be declared final</td>
+ <td>Parameter 'key' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L281">281</a></td>
</tr>
<tr class="a">
- <td>Parameter 'key' is not assigned and could be declared final</td>
+ <td>Parameter 'mapKey' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L281">281</a></td>
</tr>
<tr class="b">
@@ -2212,11 +2254,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L340">340</a></td>
</tr>
<tr class="b">
- <td>Parameter 'key' is not assigned and could be declared final</td>
+ <td>Parameter 'stateMap' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L365">365</a></td>
</tr>
<tr class="a">
- <td>Parameter 'stateMap' is not assigned and could be declared final</td>
+ <td>Parameter 'key' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L365">365</a></td>
</tr>
<tr class="b">
@@ -2244,11 +2286,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L382">382</a></td>
</tr>
<tr class="b">
- <td>Parameter 'stateMap' is not assigned and could be declared final</td>
+ <td>Parameter 'key' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L395">395</a></td>
</tr>
<tr class="a">
- <td>Parameter 'key' is not assigned and could be declared final</td>
+ <td>Parameter 'stateMap' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L395">395</a></td>
</tr>
<tr class="b">
@@ -2290,29 +2332,29 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L471">471</a></td>
</tr>
<tr class="a">
- <td>The method 'restoreState' has a Cyclomatic Complexity of 12.</td>
+ <td>The method 'restoreState' has a Modified Cyclomatic Complexity of 11.</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L569">569</a></td>
</tr>
<tr class="b">
- <td>Parameter 'state' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a></td>
- </tr>
- <tr class="a">
- <td>Parameter 'context' is not assigned and could be declared final</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a></td>
- </tr>
- <tr class="b">
<td>The method 'restoreState' has a Standard Cyclomatic Complexity of 11.</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L569">569</a></td>
</tr>
<tr class="a">
- <td>The method 'restoreState' has a Modified Cyclomatic Complexity of 11.</td>
+ <td>The method 'restoreState' has a Cyclomatic Complexity of 12.</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a>–<a
href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L569">569</a></td>
</tr>
<tr class="b">
+ <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a></td>
+ </tr>
+ <tr class="a">
+ <td>Parameter 'state' is not assigned and could be declared final</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L515">515</a></td>
+ </tr>
+ <tr class="b">
<td>Local variable 'serializedState' could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L520">520</a></td>
</tr>
@@ -2410,20 +2452,20 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L658">658</a></td>
</tr>
<tr class="b">
- <td>Document empty method</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L666">666</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L667">667</a></td>
- </tr>
- <tr class="a">
<td>Parameter 'newTransientValue' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L666">666</a></td>
</tr>
+ <tr class="a">
+ <td>Document empty method body</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L666">666</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L667">667</a></td>
+ </tr>
<tr class="b">
- <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td>Parameter 'state' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L669">669</a></td>
</tr>
<tr class="a">
- <td>Parameter 'state' is not assigned and could be declared final</td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L669">669</a></td>
</tr>
<tr class="b">
@@ -2463,11 +2505,11 @@
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L712">712</a></td>
</tr>
<tr class="a">
- <td>Parameter 'stateObj' is not assigned and could be declared final</td>
+ <td>Parameter 'context' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L726">726</a></td>
</tr>
<tr class="b">
- <td>Parameter 'context' is not assigned and could be declared final</td>
+ <td>Parameter 'stateObj' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/DeltaStateHelper.html#L726">726</a></td>
</tr>
<tr class="a">
@@ -2556,17 +2598,25 @@
href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L142">142</a></td>
</tr>
<tr class="b">
- <td>Parameter 'name' is not assigned and could be declared final</td>
+ <td>Parameter 'expression' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L145">145</a></td>
</tr>
<tr class="a">
- <td>Parameter 'expression' is not assigned and could be declared final</td>
+ <td>Parameter 'name' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L145">145</a></td>
</tr>
<tr class="b">
+ <td>Ternary operators that can be simplified with || or &&</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L170">170</a></td>
+ </tr>
+ <tr class="a">
<td>Parameter 'disabled' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L174">174</a></td>
</tr>
+ <tr class="b">
+ <td>Ternary operators that can be simplified with || or &&</td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L180">180</a></td>
+ </tr>
<tr class="a">
<td>Parameter 'immediate' is not assigned and could be declared final</td>
<td><a href="./xref/org/apache/myfaces/tobago/internal/behavior/EventBehavior.html#L184">184</a></td>
@@ -2633,8 +2683,8 @@
<td>No abstract method which means that the keyword is most likely used to prevent instantiation. Use a
private or protected constructor instead.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIBar.html#L22">22</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIBar.html#L25">25</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIBar.html#L25">25</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIBar.html#L26">26</a></td>
</tr>
</table>
</div>
@@ -2650,8 +2700,8 @@
<td>No abstract method which means that the keyword is most likely used to prevent instantiation. Use a
private or protected constructor instead.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButton.html#L22">22</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButton.html#L24">24</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButton.html#L25">25</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButton.html#L27">27</a></td>
</tr>
</table>
</div>
@@ -2667,8 +2717,8 @@
<td>No abstract method which means that the keyword is most likely used to prevent instantiation. Use a
private or protected constructor instead.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButtons.html#L22">22</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButtons.html#L23">23</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButtons.html#L25">25</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIButtons.html#L26">26</a></td>
</tr>
</table>
</div>
@@ -2681,22 +2731,16 @@
<th>Line</th>
</tr>
<tr class="a">
- <td>Avoid unused private fields such as 'LOG'.</td>
- <td><a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L34">34</a>
- </td>
- </tr>
- <tr class="b">
<td>Parameter 'submittedCollapsed' is not assigned and could be declared final</td>
<td><a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L85">85</a>
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L84">84</a>
</td>
</tr>
- <tr class="a">
+ <tr class="b">
<td>Avoid if (x != y) ..; else ..;</td>
<td><a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L92">92</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L96">96</a>
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L91">91</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.html#L95">95</a>
</td>
</tr>
</table>
@@ -2705,16 +2749,16 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagointernalcomponentAbstractUIColumnNode.java"></a>Tobago Core -
org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>No abstract method which means that the keyword is most likely used to prevent instantiation. Use a
private or protected constructor instead.
</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.html#L27">27</a>–<a
- href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.html#L28">28</a></td>
+ <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.html#L29">29</a>–<a
+ href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIColumnNode.html#L30">30</a></td>
</tr>
</table>
</div>
@@ -2722,14 +2766,14 @@
<h3><a name="Tobago_Core_-_orgapachemyfacestobagointernalcomponentAbstractUIColumnSelector.java"></a>Tobago
Core - org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.java</h3>
<table border="0" class="bodyTable">
- <tr class="b">
+ <tr class="a">
<th>Violation</th>
<th>Line</th>
</tr>
- <tr class="a">
+ <tr class="b">
<td>An empty method in an abstract class should be abstract instead</td>
- <td><a href="./xref/org/apache/myfaces/tobago/internal/component/AbstractUIColumnSelector.html#L32">32</a>–<a
[... 14515 lines stripped ...]