[GitHub] [unomi] sergehuber commented on a change in pull request #266: Secure the unomi logs

[GitBox <gi...@apache.org>]

sergehuber commented on a change in pull request #266:
URL: https://github.com/apache/unomi/pull/266#discussion_r598682314



##########
File path: plugins/request/src/main/java/org/apache/unomi/plugins/request/actions/SetRemoteHostInfoAction.java
##########
@@ -232,9 +232,9 @@ private boolean ipLookupInDatabase(String remoteAddr, Session session) {
             }
             return true;
         } catch (IOException | GeoIp2Exception e) {
-            logger.warn("Cannot resolve IP {}, enable debug log level for complete stacktrace", remoteAddr);
+            logger.warn("Cannot resolve IP, enable debug log level for complete stacktrace");
             if (logger.isDebugEnabled()) {
-                logger.debug("Cannot resolve IP", e);
+                logger.debug("Cannot resolve IP: " + remoteAddr, e);

Review comment:
       I don't always remember this, can't we use something like:
   logger.debug("Cannot resolve IP: {} because of {}", remoteAddr, e)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org