You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/05/05 06:24:29 UTC

[GitHub] [knox] smolnar82 commented on a change in pull request #447: KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata.

smolnar82 commented on a change in pull request #447:
URL: https://github.com/apache/knox/pull/447#discussion_r626278725



##########
File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/JDBCTokenStateService.java
##########
@@ -193,8 +194,17 @@ protected void evictExpiredTokens() {
 
   @Override
   public void addMetadata(String tokenId, TokenMetadata metadata) {
+
     try {
-      final boolean added = tokenDatabase.addMetadata(tokenId, metadata);
+      boolean added = false;

Review comment:
       Thanks, @moresandeep ! I've just submitted a new PS with the fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org