You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/12/30 20:05:49 UTC

Review Request 64876: Fixed `getExecutorRunPath` to handle nested ContainerIDs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64876/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Jie Yu.


Bugs: MESOS-8366
    https://issues.apache.org/jira/browse/MESOS-8366


Repository: mesos


Description
-------

If `getExecutorRunPath` is passed a nested ContainerID, it
naively stringifies it, producing an invalid executor path.
Since the executor is always the root container, we should
stringify only the root ContainerID.


Diffs
-----

  src/slave/paths.cpp 9f8ee391dec0472b6db1840bad691b4ef024ce9c 


Diff: https://reviews.apache.org/r/64876/diff/1/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach