You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/20 12:31:52 UTC
[GitHub] [incubator-doris] yangzhg opened a new pull request #2818: fix some
mistake in pom.xml
yangzhg opened a new pull request #2818: fix some mistake in pom.xml
URL: https://github.com/apache/incubator-doris/pull/2818
fix some wrong configurations in pom.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2818: fix some mistake in pom.xml
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #2818: fix some mistake in pom.xml
URL: https://github.com/apache/incubator-doris/pull/2818#discussion_r368782426
##########
File path: fe/pom.xml
##########
@@ -608,7 +609,7 @@ under the License.
<goal>exec</goal>
</goals>
<configuration>
- <executable>${env.JAVA_HOME}/bin/java</executable>
+ <executable>${java.home}/bin/java</executable>
Review comment:
maven document prefer to use java.home
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #2818: fix some
mistake in pom.xml
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #2818: fix some mistake in pom.xml
URL: https://github.com/apache/incubator-doris/pull/2818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] imay commented on a change in pull request #2818:
fix some mistake in pom.xml
Posted by GitBox <gi...@apache.org>.
imay commented on a change in pull request #2818: fix some mistake in pom.xml
URL: https://github.com/apache/incubator-doris/pull/2818#discussion_r368578228
##########
File path: fe/pom.xml
##########
@@ -608,7 +609,7 @@ under the License.
<goal>exec</goal>
</goals>
<configuration>
- <executable>${env.JAVA_HOME}/bin/java</executable>
+ <executable>${java.home}/bin/java</executable>
Review comment:
what does java.home mean? Why not use env.JAVA_HOME?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org