You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Fabian Hueske (JIRA)" <ji...@apache.org> on 2016/01/26 13:29:39 UTC
[jira] [Closed] (FLINK-1045) Remove Combinable Annotation
[ https://issues.apache.org/jira/browse/FLINK-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Fabian Hueske closed FLINK-1045.
--------------------------------
Resolution: Implemented
Implemented with 5914e9ab3fa8e8be8fff9d7e6c10d612af7e27cf
> Remove Combinable Annotation
> ----------------------------
>
> Key: FLINK-1045
> URL: https://issues.apache.org/jira/browse/FLINK-1045
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Blocker
> Labels: api-change, breaking-api
> Fix For: 1.0.0
>
>
> Since the {{combine()}} method was extracted into an interface, we can check if a function is combinable by checking if the interface is implemented.
> Hence, the {{Combinable}} annotation could be removed, IMHO.
> However, this would change the API because {{RichGroupReduceFunction}} could no longer have a default implementation of {{combine()}} that can be enabled by attaching the annotation.
> Right now, the {{Combinable}} annotation is just not necessary as the implementation of the interface tells the system everything it needs to know.
> Removing the {{Combinable}} annotation would also make the handling of different combinable functions easier. For example a function that implements the interfaces {{GroupReduceFunction}} and {{FlatCombineFunction}} does not need to attach the annotation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)