You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/18 08:24:11 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #6214: Docs: Update the view spec
ajantha-bhat opened a new pull request, #6214:
URL: https://github.com/apache/iceberg/pull/6214
some follow-up from https://github.com/apache/iceberg/pull/3188
Other than some comments add detailed examples. I have handled all. Examples can be added in the follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#discussion_r1033021228
##########
format/view-spec.md:
##########
@@ -58,16 +55,16 @@ Writers create view metadata files optimistically, assuming that the current met
The view version metadata file has the following fields:
-| Required/Optional | Field Name | Description |
-|-------------------|------------|-------------|
-| Required | format-version | An integer version number for the view format. Currently, this must be 1. Implementations must throw an exception if the view's version is higher than the supported version. |
-| Required | location | The view's base location. This is used to determine where to store manifest files and view metadata files. |
Review Comment:
No need for "the". It is fine to say "where to store view metadata files".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on code in PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#discussion_r1026144988
##########
format/view-spec.md:
##########
@@ -58,16 +55,16 @@ Writers create view metadata files optimistically, assuming that the current met
The view version metadata file has the following fields:
-| Required/Optional | Field Name | Description |
-|-------------------|------------|-------------|
-| Required | format-version | An integer version number for the view format. Currently, this must be 1. Implementations must throw an exception if the view's version is higher than the supported version. |
-| Required | location | The view's base location. This is used to determine where to store manifest files and view metadata files. |
Review Comment:
I was reading the spec today and these 'manifest files' caught my attention. Then I wanted to see why it is missed in the review. Later found that there are open comments on the same. So, handled most of the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6214:
URL: https://github.com/apache/iceberg/pull/6214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#discussion_r1033021155
##########
format/view-spec.md:
##########
@@ -32,14 +32,11 @@ Each compute engine stores the metadata of the view in its proprietary format in
## Goals
* A common metadata format for view metadata, similar to how Iceberg supports a common table format for tables.
-* The view metadata format specification
- * Includes storage format as well as APIs to write/read the metadata.
- * Supports versioning of views to track how a view evolved over time.
## Overview
View metadata storage mirrors how Iceberg table metadata is stored and retrieved. View metadata is maintained in metadata files. All changes to view state create a new view metadata file and completely replace the old metadata using an atomic swap. Like Iceberg tables, this atomic swap is delegated to the metastore that tracks tables and/or views by name. The view metadata file tracks the view schema, custom properties, current and past versions, as well as other metadata.
-Each metadata file is self-sufficient. It contains the history of the last few operations performed on the view and can be used to roll back the view to a previous version.
+Each metadata file is self-sufficient. It contains the history of the last few operations performed on the view. The view can be roll back to a previous version using these version ids.
Review Comment:
I don't think this needs to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#issuecomment-1319687679
cc: @rdblue , @jzhuge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#discussion_r1033021475
##########
format/view-spec.md:
##########
@@ -58,16 +55,16 @@ Writers create view metadata files optimistically, assuming that the current met
The view version metadata file has the following fields:
-| Required/Optional | Field Name | Description |
-|-------------------|------------|-------------|
-| Required | format-version | An integer version number for the view format. Currently, this must be 1. Implementations must throw an exception if the view's version is higher than the supported version. |
-| Required | location | The view's base location. This is used to determine where to store manifest files and view metadata files. |
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6214: Docs: Update the view spec
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6214:
URL: https://github.com/apache/iceberg/pull/6214#issuecomment-1328356702
Thanks, @ajantha-bhat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org