[jira] [Commented] (FLINK-8912) Web UI does not render error messages correctly in FLIP-6 mode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449835#comment-16449835 ] 

ASF GitHub Bot commented on FLINK-8912:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5907

    [FLINK-8912][WebUI] Update error handling for flip6

    ## What is the purpose of the change
    
    This PR updates the error handling in the webUI to support Flip6. Error reporting was standardized with the REST rework, but is slightly different than in the past.
    
    The existing error handling code was checking whether the response contained an `error` field (or just returned the entire payload if the status code indicates an error), whereas with the rework every error has contains an `errors` array.
    
    Various checks were added to account or both cases.
    
    ## Verifying this change
    
    - manually verified


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8912

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5907
    
----
commit c4081d43b3b0a6ffc60320bbb3076246ca75c240
Author: zentol <ch...@...>
Date:   2018-04-24T13:17:44Z

    [FLINK-8912][WebUI] Update error handling for flip6

----


> Web UI does not render error messages correctly in FLIP-6 mode
> --------------------------------------------------------------
>
>                 Key: FLINK-8912
>                 URL: https://issues.apache.org/jira/browse/FLINK-8912
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.5.0
>         Environment: commit: c531486288caf5241cdf7f0f00f087f3ce82239f
>            Reporter: Gary Yao
>            Assignee: Chesnay Schepler
>            Priority: Critical
>              Labels: flip6
>             Fix For: 1.5.0
>
>
> *Description*
> The Web UI renders error messages returned by the REST API incorrectly, e.g., on the job submission page. The JSON returned by the REST API is rendered as a whole. However, the UI should only render the contents of the {{errors}} field.
> *Steps to reproduce*
> Submit {{examples/streaming/SocketWindowWordCount.jar}} without specifying program arguments. Error message will be rendered as follows:
> {noformat}
> {"errors":["org.apache.flink.client.program.ProgramInvocationException: The program plan could not be fetched - the program aborted pre-maturely.\n\nSystem.err: (none)\n\nSystem.out: No port specified. Please run 'SocketWindowWordCount --hostname <hostname> --port <port>', where hostname (localhost by default) and port is the address of the text server\nTo start a simple text server, run 'netcat -l <port>' and type the input text into the command line\n"]}
> {noformat}
> Note that flip6 mode must be enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)