You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2018/08/16 20:15:17 UTC
Review Request 68393: Fixed grpc compilation for directory paths with
symlinks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68393/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Repository: mesos
Description
-------
Automake variable `abs_builddir` doesn't resolve symlinks so we
explicitly call `realpath` on grpc targets.
Diffs
-----
3rdparty/Makefile.am 248d517874c2b34e98446d1e6724078c5c21708c
Diff: https://reviews.apache.org/r/68393/diff/1/
Testing
-------
Thanks,
Kapil Arya
Re: Review Request 68393: Fixed grpc compilation for directory paths
with symlinks.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68393/#review207439
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Aug. 16, 2018, 8:15 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68393/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 8:15 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Automake variable `abs_builddir` doesn't resolve symlinks so we
> explicitly call `realpath` on grpc targets.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am 248d517874c2b34e98446d1e6724078c5c21708c
>
>
> Diff: https://reviews.apache.org/r/68393/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kapil Arya
>
>