[GitHub] [incubator-seatunnel] zhuangchong commented on a diff in pull request #3065: [Improve] Using Collections.emptyMap() replaced Collections.EMPTY_MAP

[GitBox <gi...@apache.org>]

zhuangchong commented on code in PR #3065:
URL: https://github.com/apache/incubator-seatunnel/pull/3065#discussion_r992294121


##########
seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/source/enumerator/IcebergBatchSplitEnumerator.java:
##########
@@ -41,7 +41,7 @@ public IcebergBatchSplitEnumerator(@NonNull SourceSplitEnumerator.Context<Iceber
                                        @NonNull SourceConfig sourceConfig,
                                        IcebergSplitEnumeratorState restoreState) {
         super(context, sourceConfig, restoreState != null ?
-            restoreState.getPendingSplits() : Collections.EMPTY_MAP);
+            restoreState.getPendingSplits() : Collections.emptyMap());

Review Comment:
   Why replace that? The two implementations are the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org