You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/02 18:31:23 UTC

[GitHub] [airflow] baryluk commented on pull request #17325: s3 unify_bucket_name_and_key simplify

baryluk commented on pull request #17325:
URL: https://github.com/apache/airflow/pull/17325#issuecomment-891241943


   > I think you are right. However, as you say, `if key_name` always evaluated to True, and I think `if key_name` in this PR also always evaluated to True. So should you remove this check condition? This check seems like redundant
   
   Always evaluated to `True`. But if the exception is thrown, this line is not even reached.
   
   The code is correct, and the check is not redundant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org