You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:41:29 UTC

[GitHub] [beam] aromanenko-dev edited a comment on pull request #11357: [BEAM-7770] Add ReadAll transform for SolrIO

aromanenko-dev edited a comment on pull request #11357:
URL: https://github.com/apache/beam/pull/11357#issuecomment-634050866


   Since `readAll()` is a new public API method, please, add test(s) for it. Apart from that, it's fine for me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org