You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Eric Biederman <eb...@xmission.com> on 2013/10/29 07:47:05 UTC
Review Request 15013: stout format: Expand format to handle 11 parameters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15013/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Repository: mesos-git
Description
-------
While adding additional parameters to monitor I ran into a case where
I was calling format with 11 arguments. Expand the template to handle
this case.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 71b5986
Diff: https://reviews.apache.org/r/15013/diff/
Testing
-------
make and make check pass
Thanks,
Eric Biederman
Re: Review Request 15013: stout format: Expand format to handle 11 parameters
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 31, 2013, 10:33 p.m., Ben Mahler wrote:
> > Ship It!
Thanks! Please mark this submitted.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15013/#review27970
-----------------------------------------------------------
On Oct. 29, 2013, 6:47 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15013/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> While adding additional parameters to monitor I ran into a case where
> I was calling format with 11 arguments. Expand the template to handle
> this case.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 71b5986
>
> Diff: https://reviews.apache.org/r/15013/diff/
>
>
> Testing
> -------
>
> make and make check pass
>
>
> Thanks,
>
> Eric Biederman
>
>
Re: Review Request 15013: stout format: Expand format to handle 11 parameters
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15013/#review27970
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 29, 2013, 6:47 a.m., Eric Biederman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15013/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:47 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> While adding additional parameters to monitor I ran into a case where
> I was calling format with 11 arguments. Expand the template to handle
> this case.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 71b5986
>
> Diff: https://reviews.apache.org/r/15013/diff/
>
>
> Testing
> -------
>
> make and make check pass
>
>
> Thanks,
>
> Eric Biederman
>
>