You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2024/09/06 22:38:01 UTC
[PR] I found a broken link on our website. [datasketches-website]
leerho opened a new pull request, #189:
URL: https://github.com/apache/datasketches-website/pull/189
So I used a tool to search for broken links.
This should fix most of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] I found a broken link on our website. [datasketches-website]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #189:
URL: https://github.com/apache/datasketches-website/pull/189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] I found a broken link on our website. [datasketches-website]
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #189:
URL: https://github.com/apache/datasketches-website/pull/189#discussion_r1750536129
##########
docs/HLL/Hll_vs_CS_Hllpp.md:
##########
@@ -226,7 +226,7 @@ Depending on the chosen configuration, the *HllSketch* can be from one to almost
****
* [1] [DataSketches HllSketch GitHub](https://github.com/apache/datasketches-java/tree/master/src/main/java/org/apache/datasketches/hll)
-* [2] [DataSketches HllSketch JavaDocs](/api/java/snapshot/apidocs/index.html)
+* [2] [DataSketches HllSketch JavaDocs (top of page)](https://datasketches.apache.org/docs/Background/TheChallenge.html)
Review Comment:
The original link is clearly broken because we changed the way we access the javadocs.
The natural replacement for that link would be
`https://apache.github.io/datasketches-java/6.0.0/org/apache/datasketches/hll/package-summary.html`
But notice that it refers to a specific release 6.0.0, which would be a maintenance nightmare. I replaced it at too high of a level. I should have just pointed it to https://datasketches.apache.org/docs/HLL/HLL.html
Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] I found a broken link on our website. [datasketches-website]
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #189:
URL: https://github.com/apache/datasketches-website/pull/189#discussion_r1749533006
##########
docs/HLL/Hll_vs_CS_Hllpp.md:
##########
@@ -226,7 +226,7 @@ Depending on the chosen configuration, the *HllSketch* can be from one to almost
****
* [1] [DataSketches HllSketch GitHub](https://github.com/apache/datasketches-java/tree/master/src/main/java/org/apache/datasketches/hll)
-* [2] [DataSketches HllSketch JavaDocs](/api/java/snapshot/apidocs/index.html)
+* [2] [DataSketches HllSketch JavaDocs (top of page)](https://datasketches.apache.org/docs/Background/TheChallenge.html)
Review Comment:
I don't understand this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org