You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@bahir.apache.org by tzulitai <gi...@git.apache.org> on 2017/03/01 07:20:46 UTC
[GitHub] bahir-flink pull request #12: [BAHIR-94] Add link to "Linking with Optional ...
GitHub user tzulitai opened a pull request:
https://github.com/apache/bahir-flink/pull/12
[BAHIR-94] Add link to "Linking with Optional Modules" in READMEs
Without this link, Bahir users will most likely bump into questions when trying to include the connectors for Flink cluster execution.
This PR also attempts to improve the overall quality of the Flink
connector docs (typos, extra empty lines, etc.) for the upcoming 1.0
release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/bahir-flink BAHIR-94
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir-flink/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 813a190a954e96eb755151c0db939c15f6fcb7d5
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-03-01T07:17:35Z
[BAHIR-94] Add link to "Linking with Optional Modules" in READMEs
This commit also attempts to improve the overall quality of the Flink
connector docs (typos, extra empty lines, etc.) for the upcoming 1.0
release.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #12: [BAHIR-94] Add link to "Linking with Optional Modules...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/12
Good fixes, +1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink pull request #12: [BAHIR-94] Add link to "Linking with Optional ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir-flink/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir-flink issue #12: [BAHIR-94] Add link to "Linking with Optional Modules...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/bahir-flink/pull/12
I'm merging this one as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---