You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by heary-cao <gi...@git.apache.org> on 2018/10/11 10:53:21 UTC

[GitHub] spark pull request #22695: [MINOR][SQL]remove Redundant semicolons

GitHub user heary-cao opened a pull request:

    https://github.com/apache/spark/pull/22695

    [MINOR][SQL]remove Redundant semicolons

    ## What changes were proposed in this pull request?
    
    remove Redundant semicolons in SortMergeJoinExec, thanks.
    
    ## How was this patch tested?
    
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heary-cao/spark RedundantSemicolons

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22695
    
----
commit 58fe66e4e6568ebf2771491080b33d82dde03130
Author: caoxuewen <ca...@...>
Date:   2018-10-11T10:44:59Z

    remove Redundant semicolons

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    **[Test build #4369 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4369/testReport)** for PR 22695 at commit [`58fe66e`](https://github.com/apache/spark/commit/58fe66e4e6568ebf2771491080b33d82dde03130).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by heary-cao <gi...@git.apache.org>.
Github user heary-cao commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    @srowen,thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    OK, but this kind of thing isn't worth opening a PR for. If you can maybe get some related minor changes together, that's better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    **[Test build #4369 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4369/testReport)** for PR 22695 at commit [`58fe66e`](https://github.com/apache/spark/commit/58fe66e4e6568ebf2771491080b33d82dde03130).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #22695: [MINOR][SQL]remove Redundant semicolons

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22695


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22695: [MINOR][SQL]remove Redundant semicolons

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22695
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org