[GitHub] [beam] ibzib commented on pull request #15174: [WIP][BEAM-12100][BEAM-10379][BEAM-9514] AssertionError type mismatch from AggregateScanConverter

[GitBox <gi...@apache.org>]

ibzib commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-896394325


   > I am stuck now with a couple of errors related to the incompatibility of Coders like in https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testArrayAggZetasql/ and https://ci-beam.apache.org/job/beam_PreCommit_SQL_Java11_Commit/2966/testReport/junit/org.apache.beam.sdk.extensions.sql.zetasql/ZetaSqlDialectSpecTest/testCountIfZetaSQLDialect/.
   > Do you have a suggestion of how should I proceed with these?
   
   I'm guessing the reason the error message mentions "elements of type class java.lang.Object" is because of the type signature of DropNullFn. `DropNullFn<T> extends CombineFn<T, Object, Object>` DropNullFn should use generics for all three types, not just the input type. Try changing it to `DropNullFn<InputT, AccumT, OutputT> extends CombineFn<InputT, AccumT, OutputT>`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org