[site&multiproject plugins] - reorganization of goals use to gene rate sites

[Maczka Michal <mi...@imtf.ch>]

Hi!

Recently I've trying to generate multilevel sites using multiproject plugin
and I have problems with  that approach
due to some strange relationships between goals in multiproject and site
plugins


What I am trying to do exactly is to run "site:generate" goal if project is
a leaf in a project tree or "multiprojct:site" in other case.
( I am using maven.xml file for controlling that

   <goal name="site">
        <attainGoal name="multiproject:site"/>
     </goal>

)


I would like change both multiproject and site plugin to make it possible


- In site plugin:

I would like to attain "site:generate" goal from "site" goal - not other way
around


- in multiproject plugin at the end of the code of the goal 

  <goal name="multiproject:site">

  </goal>


I would like to attain site:generate goal - not "site" goal. 


I wonder if 

a) it will be still possible to include those changes in 1.0.1 release?
b) am I missing something and this will brake something or will not work? I
tested it locally and it seems to be working for me...


regards


Michal

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: one more time: [site&multiproject plugins] - reorganization of goals used to generate sites

[Brett Porter <br...@apache.org>]

Michal Maczka wrote:

> Sometime I ago I have proposed some changes in site & multiproject 
> plugins.
> I could not apply them at that time as we were releasing  1.0.1 version.
> Somebody has any objections against those changes (they are described 
> below)?
>
Actually, there was still some confusion about whether this was 
necessary. I'd like to avoid needing to override goals. See below:

>> - In site plugin:
>>
>> I would like to attain "site:generate" goal from "site" goal - not 
>> other way
>> around
>>
+1, it seems wrong anyway. There should also be a site:site goal.

>>
>> - in multiproject plugin at the end of the code of the goal
>>  <goal name="multiproject:site">
>>
>>  </goal>
>>
>>
>> I would like to attain site:generate goal - not "site" goal.
>
I'd prefer for this that the site goal was customisable.
maven.multiproject.site.goal=site

Then you can do
maven.multiproject.site.goal=site
or
maven.multiproject.site.goal=multiproject:site

depending on the context.

As a more general case, perhaps we should have:
maven.multiproject.type=multiproject

and flip that to multiproject:site automatically. This will also make 
multiproject:install, etc recurse properly. WDYT?

>>
>> I wonder if
>> a) it will be still possible to include those changes in 1.0.1 release?
>
As a side note, these probably won't be included in 1.0.2 either as 
that, at this stage, seems to be only core changes to fix regressions.

Cheers,
Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

one more time: [site&multiproject plugins] - reorganization of goals used to generate sites

[Michal Maczka <mm...@interia.pl>]

Sometime I ago I have proposed some changes in site & multiproject plugins.
I could not apply them at that time as we were releasing  1.0.1 version.
Somebody has any objections against those changes (they are described 
below)?

Michal

>Hi!
>
>Recently I've trying to generate multilevel sites using multiproject plugin
>and I have problems with  that approach
>due to some strange relationships between goals in multiproject and site
>plugins
>
>
>What I am trying to do exactly is to run "site:generate" goal if project is
>a leaf in a project tree or "multiprojct:site" in other case.
>( I am using maven.xml file for controlling that
>
>   <goal name="site">
>        <attainGoal name="multiproject:site"/>
>     </goal>
>
>)
>
>
>I would like change both multiproject and site plugin to make it possible
>
>
>- In site plugin:
>
>I would like to attain "site:generate" goal from "site" goal - not other way
>around
>
>
>- in multiproject plugin at the end of the code of the goal 
>
>  <goal name="multiproject:site">
>
>  </goal>
>
>
>I would like to attain site:generate goal - not "site" goal. 
>
>
>I wonder if 
>
>a) it will be still possible to include those changes in 1.0.1 release?
>b) am I missing something and this will brake something or will not work? I
>tested it locally and it seems to be working for me...
>
>
>regards
>
>
>Michal
>
>  
>

----------------------------------------------------------------------
Startuj z INTERIA.PL!!! >>> http://link.interia.pl/f1837


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: [site&multiproject plugins] - reorganization of goals use to gene rate sites

[Brett Porter <br...@apache.org>]

Michal,

Sorry, don't really get this at all. Something feels wrong with it 
though. You want to run site:generate on everything, then run 
multiproject:site to do the aggregation, and set it to separate mode 
(like mavne-plugins). I don't see why you can't do that as is.

>a) it will be still possible to include those changes in 1.0.1 release?
>  
>
not a chance, sorry.

>b) am I missing something and this will brake something or will not work? I
>tested it locally and it seems to be working for me...
>
>  
>
I'll almost guarantee it will break something for someone somewhere, and 
I really don't see how it would help.

- Brett

>regards
>
>
>Michal
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org