You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/27 22:39:43 UTC
[GitHub] [beam] veblush opened a new pull request, #17486: Upgrade GCSIO to 2.2.6
veblush opened a new pull request, #17486:
URL: https://github.com/apache/beam/pull/17486
Upgraded Google Cloud Storage client (GCSIO) to the latest 2.2.6 which contains recent bug fixes and improvements around gRPC implementation. This change adds the grpc-xds dependency because it started using the Traffic Director for Directpath and this should be transparent to users.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112603354
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo merged pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo merged PR #17486:
URL: https://github.com/apache/beam/pull/17486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112601980
Run SQL_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1115029323
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111548355
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112628698
> @veblush The ticket ID in the PR suffix is the ticket that records dependency upgrades. Beam project automatically creates the tickets for each dependencies. In this case, it should be https://issues.apache.org/jira/browse/BEAM-8688 (This seems down now)
Tomo, the name of this PR starts with `[BEAM-8688]` and I thought it's enough. What else it needs to have? Should it be suffix? or a different format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1113814006
@suztomo Huh, that's interesting. Thanks for running the test. (I'm not sure why I couldn't catch it earlier with my test runs) https://github.com/grpc/grpc-java/pull/8768 looks relevant. and this is because grpc-census happens to have a different version of gRPC. Let's me add it as a new dependency as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111555341
### Link check
```
$ ./gradlew -Ppublishing -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platform,beam-runners-google-cloud-dataflow-java :checkJavaLinkage
...
* What went wrong:
Execution failed for task ':sdks:java:io:hcatalog:compileJava'.
> Could not resolve all files for configuration ':sdks:java:io:hcatalog:compileClasspath'.
> Could not find org.pentaho:pentaho-aggdesigner-algorithm:5.1.5-jhyde.
Searched in the following locations:
- file:/usr/local/google/home/veblush/git/beam/sdks/java/io/hcatalog/offline-repository/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- file:/usr/local/google/home/veblush/.m2/repository/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- https://oss.sonatype.org/content/repositories/staging/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- https://repository.apache.org/snapshots/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- https://repository.apache.org/content/repositories/releases/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
- https://maven-central.storage-download.googleapis.com/maven2/org/pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde/pentaho-aggdesigner-algorithm-5.1.5-jhyde.pom
Required by:
project :sdks:java:io:hcatalog > org.apache.hive:hive-exec:2.1.0 > org.apache.calcite:calcite-core:1.6.0
```
Error doesn't seem to be relevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111554921
R: @suztomo
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112668239
My local invocation found dependency conflicts in gRPC classes.
```
Class io.grpc.ClientStreamTracer$InternalLimitedInfoFactory is not found;
Exception in thread "main" referenced by 2 class files
io.grpc.census.CensusStatsModule (io.grpc:grpc-census:1.43.2)
io.grpc.census.CensusTracingModule (io.grpc:grpc-census:1.43.2)
Cause:
Dependency conflict: io.grpc:grpc-api:1.44.0 does not define Class io.grpc.ClientStreamTracer$InternalLimitedInfoFactory but io.grpc:grpc-api:1.43.2 defines it.
selected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.39.0-SNAPSHOT / io.grpc:grpc-api:1.44.0 (compile
unselected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.39.0-SNAPSHOT / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.39.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.2.6 (compile) / io.grpc:grpc-census:1.43.2 (compile) / io.grpc:grpc-api:1.43.2 (compile)
Dependency conflict: io.grpc:grpc-api:1.44.0 does not define Class io.grpc.ClientStreamTracer$InternalLimitedInfoFactory but io.grpc:grpc-api:1.43.2 defines it.
selected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.39.0-SNAPSHOT / io.grpc:grpc-api:1.44.0 (compile)
unselected: org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.39.0-SNAPSHOT / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.39.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.2.6 (compile) / io.grpc:grpc-census:1.43.2 (compile) / io.grpc:grpc-api:1.43.2 (compile)
Problematic artifacts in the dependency tree:
io.grpc:grpc-census:1.43.2 is at:
org.apache.beam:beam-sdks-java-io-google-cloud-platform:jar:2.39.0-SNAPSHOT / org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core:2.39.0-SNAPSHOT (compile) / com.google.cloud.bigdataoss:gcsio:2.2.6 (compile) / io.grpc:grpc-census:1.43.2 (compile)
```
https://gist.github.com/suztomo/7593d67629f61ce0395335bf911e6e43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112629185
Oh, I thought I changed but it seems that you did. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1115138617
Nice. No new linkage errors https://gist.github.com/suztomo/0a2b2939876997dbc2312b69b9490104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111548358
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111568745
I haven't run the linkage check on Beam for a while.
Memo: org.pentaho:pentaho-aggdesigner-algorithm is [Spring Plugins](https://mvnrepository.com/repos/springio-plugins-release) repository (https://repo.spring.io/plugins-release/) as per https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112603188
Run SQL Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112603457
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on a diff in pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on code in PR #17486:
URL: https://github.com/apache/beam/pull/17486#discussion_r860334117
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -609,6 +609,8 @@ class BeamModulePlugin implements Plugin<Project> {
grpc_netty : "io.grpc:grpc-netty", // google_cloud_platform_libraries_bom sets version
grpc_netty_shaded : "io.grpc:grpc-netty-shaded", // google_cloud_platform_libraries_bom sets version
grpc_stub : "io.grpc:grpc-stub", // google_cloud_platform_libraries_bom sets version
+ // Once grpc-xds is added to google_cloud_platform_libraries_bom, use google_cloud_platform_libraries_bom instead.
+ grpc_xds : "io.grpc:grpc-xds:$grpc_version",
Review Comment:
Oh I added it to `sdks/java/io/google-cloud-platform/build.gradle`. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] veblush commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
veblush commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112434058
> I haven't run the linkage check on Beam for a while.
>
> Memo: org.pentaho:pentaho-aggdesigner-algorithm is [Spring Plugins](https://mvnrepository.com/repos/springio-plugins-release) repository (https://repo.spring.io/plugins-release/) as per https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde.
I got the same error when running the linkage check on the master so I think it's not a regression caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112608260
@veblush The ticket ID in the PR suffix is the ticket that records dependency upgrades. Beam project automatically creates the tickets for each dependencies. In this case, it should be https://issues.apache.org/jira/browse/BEAM-8688 (This seems down now)
https://beam.apache.org/contribute/get-started-contributing/#create-a-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111562271
# [Codecov](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17486](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24abf1f) into [master](https://codecov.io/gh/apache/beam/commit/53786bc75d3d3d7ead31a49cd03b8b00f4d2a560?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53786bc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17486 +/- ##
=======================================
Coverage 73.83% 73.84%
=======================================
Files 690 690
Lines 90829 90829
=======================================
+ Hits 67068 67069 +1
+ Misses 22552 22551 -1
Partials 1209 1209
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.66% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.44% <0.00%> (-0.65%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/17486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.90% <0.00%> (-0.16%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.51% <0.00%> (-0.13%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/17486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==) | `89.20% <0.00%> (+1.70%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17486/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53786bc...24abf1f](https://codecov.io/gh/apache/beam/pull/17486?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112603544
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1111548359
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17486: [BEAM-8688] Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17486:
URL: https://github.com/apache/beam/pull/17486#issuecomment-1112802775
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on a diff in pull request #17486: Upgrade GCSIO to 2.2.6
Posted by GitBox <gi...@apache.org>.
suztomo commented on code in PR #17486:
URL: https://github.com/apache/beam/pull/17486#discussion_r860304845
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -609,6 +609,8 @@ class BeamModulePlugin implements Plugin<Project> {
grpc_netty : "io.grpc:grpc-netty", // google_cloud_platform_libraries_bom sets version
grpc_netty_shaded : "io.grpc:grpc-netty-shaded", // google_cloud_platform_libraries_bom sets version
grpc_stub : "io.grpc:grpc-stub", // google_cloud_platform_libraries_bom sets version
+ // Once grpc-xds is added to google_cloud_platform_libraries_bom, use google_cloud_platform_libraries_bom instead.
+ grpc_xds : "io.grpc:grpc-xds:$grpc_version",
Review Comment:
Declaring this key in the map doesn't have any effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org