You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by joewitt <gi...@git.apache.org> on 2016/03/11 16:35:42 UTC
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/270
NIFI-1511 now only sets groovy eclipse compiler for test compiles
NIFI-1511 now only sets groovy eclipse compiler for test compiles
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-1511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit aaee620dc858d83e92a32145e15548728c3c61c3
Author: joewitt <jo...@apache.org>
Date: 2016-03-11T15:33:46Z
NIFI-1511 now only sets groovy eclipse compiler for test compiles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/270#issuecomment-195421597
reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/270#issuecomment-195432609
Although the commits should be squashed :) Will merge once this is done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/270#issuecomment-195434033
operation squash that jazz be complete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1511 now only sets groovy eclipse compiler...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/270#issuecomment-195431123
+1 LGTM, local and Travis tests passed, with groovy-eclipse compiler only used on modules with Groovy tests inside (nifi-web-security, nifi-standard-processors, e.g.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---