You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/04/08 20:57:07 UTC

[GitHub] [hbase] gjacoby126 commented on a change in pull request #3136: HBASE-25750 Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX)

gjacoby126 commented on a change in pull request #3136:
URL: https://github.com/apache/hbase/pull/3136#discussion_r610098518



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcController.java
##########
@@ -37,7 +39,8 @@
  * RegionInfo we're making the call against if relevant (useful adding info to exceptions and logs).
  * Used by client and server ipc'ing.
  */
-@InterfaceAudience.Private
+@InterfaceAudience.LimitedPrivate({HBaseInterfaceAudience.COPROC, HBaseInterfaceAudience.PHOENIX})

Review comment:
       @apurtell - we may want to also add HBaseInterfaceAudience.REPLICATION to the LimitedPrivate annotation. @bharathv and I recently tried to make a custom replication sink implementing the replication API (which I assume counts as Public?), but found we had to downcast RpcController to HBaseRpcController to get at the actual replicated Cells.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org