You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/24 16:01:51 UTC
[GitHub] [airflow] potiuk opened a new pull request #18505: Increase timeouts for setup/teardown in pytest
potiuk opened a new pull request #18505:
URL: https://github.com/apache/airflow/pull/18505
For some unknown reason recently some tests started to fail
on setup timout exceeding 20 seconds. Those tests have NO setup
so it likely a side-effect of other tests (for example with some
process cleanup that takes more time/CPU.
This change attempts to fix it by simply increasing the timeout
to 60 seconds. If it works - fine, but if not, it will be indication
that we have a deeper problem to fix.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #18505: Increase timeouts for setup/teardown in pytest
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18505:
URL: https://github.com/apache/airflow/pull/18505#discussion_r715791264
##########
File path: scripts/in_container/entrypoint_ci.sh
##########
@@ -215,9 +215,9 @@ EXTRA_PYTEST_ARGS=(
# timeouts in seconds for individual tests
"--timeouts-order"
"moi"
- "--setup-timeout=20"
+ "--setup-timeout=60"
Review comment:
Indeed, setup-timeout of more than 20-30s seems very odd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18505: Increase timeouts for setup/teardown in pytest
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18505:
URL: https://github.com/apache/airflow/pull/18505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org