You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2023/08/31 20:50:41 UTC
[superset] branch master updated: fix: Handle Python date format for GENERIC_CHART_AXES feature (#25135)
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new de9515c294 fix: Handle Python date format for GENERIC_CHART_AXES feature (#25135)
de9515c294 is described below
commit de9515c29486505e81b530344d564658aa43e153
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Thu Aug 31 13:50:34 2023 -0700
fix: Handle Python date format for GENERIC_CHART_AXES feature (#25135)
---
superset/connectors/sqla/models.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index 09f5815e23..cdebe8724c 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -991,11 +991,13 @@ class SqlaTable(
time_grain = col.get("timeGrain")
has_timegrain = col.get("columnType") == "BASE_AXIS" and time_grain
is_dttm = False
+ pdf = None
if col_in_metadata := self.get_column(expression):
sqla_column = col_in_metadata.get_sqla_col(
template_processor=template_processor
)
is_dttm = col_in_metadata.is_temporal
+ pdf = col_in_metadata.python_date_format
else:
sqla_column = literal_column(expression)
if has_timegrain or force_type_check:
@@ -1012,7 +1014,7 @@ class SqlaTable(
if is_dttm and has_timegrain:
sqla_column = self.db_engine_spec.get_timestamp_expr(
col=sqla_column,
- pdf=None,
+ pdf=pdf,
time_grain=time_grain,
)
return self.make_sqla_column_compatible(sqla_column, label)