You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Corey Sterling <co...@gmail.com> on 2020/03/15 21:40:12 UTC
[VOTE] Release SAMOA 0.5.0 (incubating) RC3
Hi all,
The SAMOA community has voted to promote a release candidate to a
full-release.
The vote thread can be found at:
https://lists.apache.org/thread.html/r9ee34c67da99269915485635ae9c86e158fb9e149727e699d3990e23%40%3Cdev.samoa.apache.org%3E
and the result thread at:
https://lists.apache.org/thread.html/r066a4c6334e155887f6ab199fb9f52e0b7798a9a1940cae69a29671d%40%3Cdev.samoa.apache.org%3E
We now invite the general incubator community to vote on releasing the same
release candidate as Apache SAMOA (incubating) version 0.5.0.
Release candidate 2 was skipped as during it's creation the Github mirror
of the branch became out-of-sync with the Apache source repository.
This release will be the third release for SAMOA in the incubator.
-------------------------------------------------------------
The commit to be voted on is in the branch "releases/0.5.0-incubating-RC3"
(commit 9fe3b5582b7c697a00151902bd7e945aaf07506f):
https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
.git;a=commit;h=9fe3b5582b7c697a00151902bd7e945aaf07506f
Tag v0.5.0-incubating:
https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
.git;a=commit;h=856a16920f7c19f94c43c3cdd287a86f52087c15
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/csterling
The staging repository for this release can be found at:
https://repository.apache.org/content/repositories/staging/org/apache/samoa/
samoa/0.5.0-incubating/
The developer's version artifacts:
https://dist.apache.org/repos/dist/dev/incubator/samoa/0.5.0-incubating-rc3/
-------------------------------------------------------------
Please vote on releasing this package as Apache SAMOA 0.5.0 (incubating).
[ ] +1 Release this package as Apache SAMOA 0.5.0 (incubating)
[ ] -1 Do not release this package because ...
Cheers,
Corey.
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Alan Gates <al...@gmail.com>.
I’ll take a look this weekend or early next week.
Alan.
Sent from my iPhone
> On Apr 10, 2020, at 17:53, Justin Mclean <jm...@apache.org> wrote:
>
> Hi,
>
> Look like this needs another IPMC vote, can any IPMC member help?
>
> Thanks,
> Justin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Justin Mclean <jm...@apache.org>.
Hi,
Look like this needs another IPMC vote, can any IPMC member help?
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Alan Gates <al...@gmail.com>.
+1. I checked the disclaimer, license, and notice files, the hash and key
signature. I did a build from source and ran the rat check.
One note on the rat check, five files fail. One of those is s shell script
that could have the license added, the others look like maybe they
couldn't. But it would be nice to put those in the exclude list so the rat
build succeeds. This can be done after this release.
Alan.
On Tue, Mar 24, 2020 at 3:14 PM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> > So the best I could do was to include the SHA512 with the developer
> artefacts.
>
> That all that’s needed change my vote to:
>
> +1 (binding)
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> So the best I could do was to include the SHA512 with the developer artefacts.
That all that’s needed change my vote to:
+1 (binding)
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Corey Sterling <co...@gmail.com>.
That is correct. The SHA1/MD5 files are automatically generated by the Maven Release Plugin, and there doesn't seem to be anyway to configure this to use SHA512 or override it. Furthermore:
https://infra.apache.org/maven-releases.html
states:
"
Don't try to publish .sha256 or .sha512 files; Nexus doesn't handle them
"
So the best I could do was to include the SHA512 with the developer artefacts.
On 2020/03/18 04:22:43, Paul King <pa...@asert.com.au> wrote:
> Looks like under "The developer's version artifacts" you have the sha512
> hashes, but under the staging repo you just have sha1/md5.
>
>
> On Wed, Mar 18, 2020 at 7:58 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > HI,
> >
> > -1 (binding) because of hash issue - but this is easily fixed without
> > stopping the vote and there’s no need for a revote. Once change I check and
> > change my vote to +1
> >
> > I checked:
> > - incubating in name
> > - signature is fine (although it would be good to sigh with an apache
> > email address)
> > - hash needs to be sha256 or sha512 [1]
> > - DISCLAIMER exits
> > - LICENSE is OKish
> > - NOTICE year is out of date (2016!) Please fix.
> > - No unexpected binary files
> > - Can compile from source
> >
> > License mentions "This product includes software developed at Yahoo! Inc.”
> > but doesn’t say how that is licensed I think this needs to be in NOTICE not
> > LICENSE as teh copyright headers have been relocated right? It also unclear
> > where the code for MOA is bundled.
> >
> > Thanks,
> > Justin
> >
> > 1. https://infra.apache.org/release-distribution-policy.html
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Paul King <pa...@asert.com.au>.
Looks like under "The developer's version artifacts" you have the sha512
hashes, but under the staging repo you just have sha1/md5.
On Wed, Mar 18, 2020 at 7:58 AM Justin Mclean <ju...@classsoftware.com>
wrote:
> HI,
>
> -1 (binding) because of hash issue - but this is easily fixed without
> stopping the vote and there’s no need for a revote. Once change I check and
> change my vote to +1
>
> I checked:
> - incubating in name
> - signature is fine (although it would be good to sigh with an apache
> email address)
> - hash needs to be sha256 or sha512 [1]
> - DISCLAIMER exits
> - LICENSE is OKish
> - NOTICE year is out of date (2016!) Please fix.
> - No unexpected binary files
> - Can compile from source
>
> License mentions "This product includes software developed at Yahoo! Inc.”
> but doesn’t say how that is licensed I think this needs to be in NOTICE not
> LICENSE as teh copyright headers have been relocated right? It also unclear
> where the code for MOA is bundled.
>
> Thanks,
> Justin
>
> 1. https://infra.apache.org/release-distribution-policy.html
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
-1 (binding) because of hash issue - but this is easily fixed without stopping the vote and there’s no need for a revote. Once change I check and change my vote to +1
I checked:
- incubating in name
- signature is fine (although it would be good to sigh with an apache email address)
- hash needs to be sha256 or sha512 [1]
- DISCLAIMER exits
- LICENSE is OKish
- NOTICE year is out of date (2016!) Please fix.
- No unexpected binary files
- Can compile from source
License mentions "This product includes software developed at Yahoo! Inc.” but doesn’t say how that is licensed I think this needs to be in NOTICE not LICENSE as teh copyright headers have been relocated right? It also unclear where the code for MOA is bundled.
Thanks,
Justin
1. https://infra.apache.org/release-distribution-policy.html
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release SAMOA 0.5.0 (incubating) RC3
Posted by Paul King <pa...@asert.com.au>.
+1 (binding) with some caveats.
I checked:
* Incubating in name
* DISCLAIMER exists
* LICENSE and NOTICE okay (copyright end year in NOTICE needs a bump I
would suspect)
* Signatures okay
* Checksums okay
My understanding is that the KEYS file for your project is expected in:
https://dist.apache.org/repos/dist/release/incubator/samoa/KEYS (or via
the external URL https://downloads.apache.org/incubator/samoa/KEYS)
It would normally contain the keys for all release managers. I believe you
can just copy your file there now - please do.
Rat indicates that the following files need headers or an exclusion (if
generated or header can't be there for some technical reason):
sign.sh
DEPENDENCIES
CONTRIBUTING.md
checkstyle/header.regexp
bin/samza-kryo
src/main/resources/kafka.avsc (samoa-api)
src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
(samoa-api)
[None of these seem like critical IP to me, so not worth cancelling but
this should be easy to fix up for next release.]
The following test failed on Ubuntu and WSL:
Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.384 sec
<<< FAILURE! - in
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest
testStartSendingEvents(org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest)
Time elapsed: 0.31 sec <<< ERROR!
java.lang.IllegalStateException: Missing invocation to mocked type at
this point; please make sure there is an associated mock field or mock
parameter in scope
at
org.apache.samoa.topology.impl.SimpleEntranceProcessingItemTest$4.<init>(SimpleEntranceProcessingItemTest.java:158)...
Additional tests failed under Windows, e.g.:
Tests run: 10, Failures: 0, Errors: 10, Skipped: 0, Time elapsed: 8.097
sec <<< FAILURE! - in org.apache.samoa.streams.fs.HDFSFileStreamSourceTest
testGetNextInputStream(org.apache.samoa.streams.fs.HDFSFileStreamSourceTest)
Time elapsed: 6.661 sec <<< ERROR!
java.lang.UnsatisfiedLinkError:
org.apache.hadoop.io.nativeio.NativeIO$Windows.access0(Ljava/lang/String;I)Z...
Attempting to test under Windows with JDK 11.0.5 gave:
[ERROR] Caused by: java.lang.IllegalStateException: JMockit requires a
Java 6+ VM
[ERROR] at
mockit.internal.startup.AgentInitialization.loadAgentFromLocalJarFile(AgentInitialization.java:25)
[I am assuming there is something I don't have set up correctly in my
environment but would be good for you to list recommended JDK
versions/platforms in your vote email (and release email) if there are
restrictions, or point to some doco where such info is available]
I could build from source using `mvn -Dmaven.test.skip=true package` and
was then able to run the classifiers.ensemble.Bagging example from the
project home page.
[After printing out what looked like the results, bin/samoa didn't return
to the command prompt. I didn't know if that is expected behavior.]
Cheers, Paul.
On Mon, Mar 16, 2020 at 7:40 AM Corey Sterling <co...@gmail.com>
wrote:
> Hi all,
>
> The SAMOA community has voted to promote a release candidate to a
> full-release.
>
> The vote thread can be found at:
>
> https://lists.apache.org/thread.html/r9ee34c67da99269915485635ae9c86e158fb9e149727e699d3990e23%40%3Cdev.samoa.apache.org%3E
>
> and the result thread at:
>
> https://lists.apache.org/thread.html/r066a4c6334e155887f6ab199fb9f52e0b7798a9a1940cae69a29671d%40%3Cdev.samoa.apache.org%3E
>
> We now invite the general incubator community to vote on releasing the same
> release candidate as Apache SAMOA (incubating) version 0.5.0.
>
> Release candidate 2 was skipped as during it's creation the Github mirror
> of the branch became out-of-sync with the Apache source repository.
>
> This release will be the third release for SAMOA in the incubator.
>
> -------------------------------------------------------------
> The commit to be voted on is in the branch "releases/0.5.0-incubating-RC3"
> (commit 9fe3b5582b7c697a00151902bd7e945aaf07506f):
> https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
> .git;a=commit;h=9fe3b5582b7c697a00151902bd7e945aaf07506f
>
> Tag v0.5.0-incubating:
> https://git-wip-us.apache.org/repos/asf?p=incubator-samoa
> .git;a=commit;h=856a16920f7c19f94c43c3cdd287a86f52087c15
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/csterling
>
> The staging repository for this release can be found at:
>
> https://repository.apache.org/content/repositories/staging/org/apache/samoa/
> samoa/0.5.0-incubating/
> <https://repository.apache.org/content/repositories/staging/org/apache/samoa/samoa/0.5.0-incubating/>
>
> The developer's version artifacts:
>
> https://dist.apache.org/repos/dist/dev/incubator/samoa/0.5.0-incubating-rc3/
>
> -------------------------------------------------------------
>
> Please vote on releasing this package as Apache SAMOA 0.5.0 (incubating).
>
> [ ] +1 Release this package as Apache SAMOA 0.5.0 (incubating)
> [ ] -1 Do not release this package because ...
>
> Cheers,
>
> Corey.
>