You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by li...@apache.org on 2020/07/27 11:59:44 UTC
[submarine] branch master updated: SUBMARINE-568. [WEB] Fix a
display bug in experiment info page
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 6ee7105 SUBMARINE-568. [WEB] Fix a display bug in experiment info page
6ee7105 is described below
commit 6ee7105c23e12e92cff74e5ee4e77afee08dfb97
Author: kobe860219 <ko...@gmail.com>
AuthorDate: Fri Jul 24 22:57:07 2020 +0800
SUBMARINE-568. [WEB] Fix a display bug in experiment info page
### What is this PR for?
* Fix problem that when reload experiment info page, the experimentID in breadcrumb will miss.
* Adjustment the presenting of experiment info output page to be more friendly for users.
### What type of PR is it?
[Feature]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-568
### How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/711355007
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: kobe860219 <ko...@gmail.com>
Closes #355 from kobe860219/SUBMARINE-568 and squashes the following commits:
e5155a9 [kobe860219] Improve the commit
8ee36c0 [kobe860219] SUBMARINE-568. [WEB] Fix a display bug in experiment info page
---
.../experiment-info/outputs/outputs.component.scss | 4 ++--
.../app/pages/workbench/experiment/experiment.component.ts | 14 ++++++++++++++
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/outputs/outputs.component.scss b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/outputs/outputs.component.scss
index 80ee29a..b1f72a4 100644
--- a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/outputs/outputs.component.scss
+++ b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/outputs/outputs.component.scss
@@ -18,8 +18,8 @@
*/
#showLogDiv{
- background-color: gainsboro;
- color: red;
+ background-color: whitesmoke;
+ color: black;
padding: 10px;
height:500px;
overflow:auto;
diff --git a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment.component.ts b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment.component.ts
index c71acb3..8b07030 100644
--- a/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment.component.ts
+++ b/submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment.component.ts
@@ -91,6 +91,8 @@ export class ExperimentComponent implements OnInit {
}
}
});
+
+ this.reloadCheck();
}
// Getters of experiment request form
@@ -215,6 +217,18 @@ export class ExperimentComponent implements OnInit {
);
}
+ reloadCheck() {
+ /*
+ When reload in info page, ths experimentId will turn into undifined, it will cause breadcrumb miss experimentId.
+ Location.pathname -> /workbench/experiment/info/{experimentID}
+ So slice out experimentId string from location.pathname to reassign experimentId.
+ */
+ if (location.pathname != '/workbench/experiment') {
+ var sliceString = new String('/workbench/experiment/info');
+ this.experimentID = location.pathname.slice(sliceString.length);
+ }
+ }
+
// TODO(jasoonn): Filter experiment list
filter(event) {
console.log(this.searchText + event.key);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org