You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by David Harland <ha...@yahoo.com> on 2008/10/28 11:34:06 UTC

Struts 2.0.12 has broken Conversion Errors!!!

Since upgrading to struts 2.0.12 from 2.0.11.1 all conversion errors are being lost.

Here is a simple example showing this is broken!

Take the Struts2 blank app for 2.0.11.1. Now add a simple Action with an Integer property testNumber. Now add a jsp with a field testNumber. Now put fred in testNumber and submit.

You get 'Invalid field value for field "testNumber".'

Now replace the lib files from the 2.0.11.1 struts2 blank with the 2.0.12.

The Conversion errors now do not get displayed. They are lost!

It appears to be the ParametersInterceptor is taking a copy of the ValueStack, the conversion errors are being set on the new stack and therefore lost.
 
Regards
 
David.


      

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Musachy Barroso <mu...@gmail.com>.
Fixed on trunk and 2.0 branch of XWork.

musachy

On Tue, Oct 28, 2008 at 10:55 AM, Musachy Barroso <mu...@gmail.com> wrote:

> Indeed. The conversion errors are set on the "fake" stack, and are never
> copied back to the original stack.
>
> musachy
>
>
> On Tue, Oct 28, 2008 at 10:46 AM, David Harland <ha...@yahoo.com>wrote:
>
>> I know the feeling ;0)
>>
>> Dave.
>>
>>
>> --- On Tue, 10/28/08, Musachy Barroso <mu...@gmail.com> wrote:
>>
>> > From: Musachy Barroso <mu...@gmail.com>
>> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
>> > To: "Struts Users Mailing List" <us...@struts.apache.org>,
>> harlander3000@yahoo.com
>> > Date: Tuesday, October 28, 2008, 3:44 PM
>> > Attention Deficit Disorder + Multi-tasking = bad emails
>> >
>> > :)
>> >
>> > musachy
>> >
>> > On Tue, Oct 28, 2008 at 10:35 AM, David Harland
>> > <ha...@yahoo.com>wrote:
>> >
>> > > 2.0.11.1 works. 2.0.12 does not.
>> > >
>> > > Regards
>> > >
>> > > Dave
>> > >
>> > >
>> > > --- On Tue, 10/28/08, Musachy Barroso
>> > <mu...@gmail.com> wrote:
>> > >
>> > > > From: Musachy Barroso <mu...@gmail.com>
>> > > > Subject: Re: Struts 2.0.12 has broken Conversion
>> > Errors!!!
>> > > > To: "Struts Users Mailing List"
>> > <us...@struts.apache.org>,
>> > > harlander3000@yahoo.com
>> > > > Date: Tuesday, October 28, 2008, 3:32 PM
>> > > > Are you sure abut this? I am running 2.0.11.1 on
>> > the test
>> > > > case that you
>> > > > mentioned, and the conversion errors are added to
>> > the
>> > > > "fieldErrors" map on
>> > > > the action. Please note that the action must
>> > implement
>> > > > ValidationAware,
>> > > > otherwise the errors will do get lost.
>> > > >
>> > > > musachy
>> > > >
>> > > > On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso
>> > > > <mu...@gmail.com> wrote:
>> > > >
>> > > > > Thanks for reporting, I will look into it.
>> > > > >
>> > > > > musachy
>> > > > >
>> > > > >
>> > > > > On Tue, Oct 28, 2008 at 6:55 AM, David
>> > Harland
>> > > > <ha...@yahoo.com>wrote:
>> > > > >
>> > > > >> Done.
>> > > > >>
>> > > > >> Thanks
>> > > > >>
>> > > > >>
>> > > > >> --- On Tue, 10/28/08, Nils-Helge Garli
>> > Hegvik
>> > > > <ni...@gmail.com> wrote:
>> > > > >>
>> > > > >> > From: Nils-Helge Garli Hegvik
>> > > > <ni...@gmail.com>
>> > > > >> > Subject: Re: Struts 2.0.12 has
>> > broken
>> > > > Conversion Errors!!!
>> > > > >> > To: "Struts Users Mailing
>> > List"
>> > > > <us...@struts.apache.org>,
>> > > > >> harlander3000@yahoo.com
>> > > > >> > Date: Tuesday, October 28, 2008,
>> > 11:49 AM
>> > > > >> > Hi!
>> > > > >> >
>> > > > >> > If you have found a bug, please
>> > register an
>> > > > issue in JIRA
>> > > > >> > and include
>> > > > >> > as much relevant information as
>> > possible.
>> > > > >> >
>> > > > >> >
>> > http://struts.apache.org/helping.html#issues
>> > > > >> >
>> > > > >> > Thanks.
>> > > > >> >
>> > > > >> > Nils-H
>> > > > >> >
>> > > > >> > On Tue, Oct 28, 2008 at 11:34 AM,
>> > David
>> > > > Harland
>> > > > >> > <ha...@yahoo.com>
>> > wrote:
>> > > > >> > > Since upgrading to struts
>> > 2.0.12 from
>> > > > 2.0.11.1 all
>> > > > >> > conversion errors are being lost.
>> > > > >> > >
>> > > > >> > > Here is a simple example
>> > showing this is
>> > > > broken!
>> > > > >> > >
>> > > > >> > > Take the Struts2 blank app for
>> > 2.0.11.1.
>> > > > Now add a
>> > > > >> > simple Action with an Integer
>> > property
>> > > > testNumber. Now add a
>> > > > >> > jsp with a field testNumber. Now
>> > put fred in
>> > > > testNumber and
>> > > > >> > submit.
>> > > > >> > >
>> > > > >> > > You get 'Invalid field
>> > value for
>> > > > field
>> > > > >> > "testNumber".'
>> > > > >> > >
>> > > > >> > > Now replace the lib files from
>> > the
>> > > > 2.0.11.1 struts2
>> > > > >> > blank with the 2.0.12.
>> > > > >> > >
>> > > > >> > > The Conversion errors now do
>> > not get
>> > > > displayed. They
>> > > > >> > are lost!
>> > > > >> > >
>> > > > >> > > It appears to be the
>> > > > ParametersInterceptor is taking a
>> > > > >> > copy of the ValueStack, the
>> > conversion errors
>> > > > are being set
>> > > > >> > on the new stack and therefore
>> > lost.
>> > > > >> > >
>> > > > >> > > Regards
>> > > > >> > >
>> > > > >> > > David.
>> > > > >> > >
>> > > > >> > >
>> > > > >> > >
>> > > > >> > >
>> > > > >> > >
>> > > > >> >
>> > > >
>> > ---------------------------------------------------------------------
>> > > > >> > > To unsubscribe, e-mail:
>> > > > >> > user-unsubscribe@struts.apache.org
>> > > > >> > > For additional commands,
>> > e-mail:
>> > > > >> > user-help@struts.apache.org
>> > > > >> > >
>> > > > >> > >
>> > > > >> >
>> > > > >> >
>> > > >
>> > ---------------------------------------------------------------------
>> > > > >> > To unsubscribe, e-mail:
>> > > > user-unsubscribe@struts.apache.org
>> > > > >> > For additional commands, e-mail:
>> > > > >> > user-help@struts.apache.org
>> > > > >>
>> > > > >>
>> > > > >>
>> > > > >>
>> > > > >>
>> > > >
>> > ---------------------------------------------------------------------
>> > > > >> To unsubscribe, e-mail:
>> > > > user-unsubscribe@struts.apache.org
>> > > > >> For additional commands, e-mail:
>> > > > user-help@struts.apache.org
>> > > > >>
>> > > > >>
>> > > > >
>> > > > >
>> > > > > --
>> > > > > "Hey you! Would you help me to carry
>> > the
>> > > > stone?" Pink Floyd
>> > > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > "Hey you! Would you help me to carry the
>> > stone?"
>> > > > Pink Floyd
>> > >
>> > >
>> > >
>> > >
>> > >
>> > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail:
>> > user-unsubscribe@struts.apache.org
>> > > For additional commands, e-mail:
>> > user-help@struts.apache.org
>> > >
>> > >
>> >
>> >
>> > --
>> > "Hey you! Would you help me to carry the stone?"
>> > Pink Floyd
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Musachy Barroso <mu...@gmail.com>.
Indeed. The conversion errors are set on the "fake" stack, and are never
copied back to the original stack.

musachy

On Tue, Oct 28, 2008 at 10:46 AM, David Harland <ha...@yahoo.com>wrote:

> I know the feeling ;0)
>
> Dave.
>
>
> --- On Tue, 10/28/08, Musachy Barroso <mu...@gmail.com> wrote:
>
> > From: Musachy Barroso <mu...@gmail.com>
> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> > To: "Struts Users Mailing List" <us...@struts.apache.org>,
> harlander3000@yahoo.com
> > Date: Tuesday, October 28, 2008, 3:44 PM
> > Attention Deficit Disorder + Multi-tasking = bad emails
> >
> > :)
> >
> > musachy
> >
> > On Tue, Oct 28, 2008 at 10:35 AM, David Harland
> > <ha...@yahoo.com>wrote:
> >
> > > 2.0.11.1 works. 2.0.12 does not.
> > >
> > > Regards
> > >
> > > Dave
> > >
> > >
> > > --- On Tue, 10/28/08, Musachy Barroso
> > <mu...@gmail.com> wrote:
> > >
> > > > From: Musachy Barroso <mu...@gmail.com>
> > > > Subject: Re: Struts 2.0.12 has broken Conversion
> > Errors!!!
> > > > To: "Struts Users Mailing List"
> > <us...@struts.apache.org>,
> > > harlander3000@yahoo.com
> > > > Date: Tuesday, October 28, 2008, 3:32 PM
> > > > Are you sure abut this? I am running 2.0.11.1 on
> > the test
> > > > case that you
> > > > mentioned, and the conversion errors are added to
> > the
> > > > "fieldErrors" map on
> > > > the action. Please note that the action must
> > implement
> > > > ValidationAware,
> > > > otherwise the errors will do get lost.
> > > >
> > > > musachy
> > > >
> > > > On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso
> > > > <mu...@gmail.com> wrote:
> > > >
> > > > > Thanks for reporting, I will look into it.
> > > > >
> > > > > musachy
> > > > >
> > > > >
> > > > > On Tue, Oct 28, 2008 at 6:55 AM, David
> > Harland
> > > > <ha...@yahoo.com>wrote:
> > > > >
> > > > >> Done.
> > > > >>
> > > > >> Thanks
> > > > >>
> > > > >>
> > > > >> --- On Tue, 10/28/08, Nils-Helge Garli
> > Hegvik
> > > > <ni...@gmail.com> wrote:
> > > > >>
> > > > >> > From: Nils-Helge Garli Hegvik
> > > > <ni...@gmail.com>
> > > > >> > Subject: Re: Struts 2.0.12 has
> > broken
> > > > Conversion Errors!!!
> > > > >> > To: "Struts Users Mailing
> > List"
> > > > <us...@struts.apache.org>,
> > > > >> harlander3000@yahoo.com
> > > > >> > Date: Tuesday, October 28, 2008,
> > 11:49 AM
> > > > >> > Hi!
> > > > >> >
> > > > >> > If you have found a bug, please
> > register an
> > > > issue in JIRA
> > > > >> > and include
> > > > >> > as much relevant information as
> > possible.
> > > > >> >
> > > > >> >
> > http://struts.apache.org/helping.html#issues
> > > > >> >
> > > > >> > Thanks.
> > > > >> >
> > > > >> > Nils-H
> > > > >> >
> > > > >> > On Tue, Oct 28, 2008 at 11:34 AM,
> > David
> > > > Harland
> > > > >> > <ha...@yahoo.com>
> > wrote:
> > > > >> > > Since upgrading to struts
> > 2.0.12 from
> > > > 2.0.11.1 all
> > > > >> > conversion errors are being lost.
> > > > >> > >
> > > > >> > > Here is a simple example
> > showing this is
> > > > broken!
> > > > >> > >
> > > > >> > > Take the Struts2 blank app for
> > 2.0.11.1.
> > > > Now add a
> > > > >> > simple Action with an Integer
> > property
> > > > testNumber. Now add a
> > > > >> > jsp with a field testNumber. Now
> > put fred in
> > > > testNumber and
> > > > >> > submit.
> > > > >> > >
> > > > >> > > You get 'Invalid field
> > value for
> > > > field
> > > > >> > "testNumber".'
> > > > >> > >
> > > > >> > > Now replace the lib files from
> > the
> > > > 2.0.11.1 struts2
> > > > >> > blank with the 2.0.12.
> > > > >> > >
> > > > >> > > The Conversion errors now do
> > not get
> > > > displayed. They
> > > > >> > are lost!
> > > > >> > >
> > > > >> > > It appears to be the
> > > > ParametersInterceptor is taking a
> > > > >> > copy of the ValueStack, the
> > conversion errors
> > > > are being set
> > > > >> > on the new stack and therefore
> > lost.
> > > > >> > >
> > > > >> > > Regards
> > > > >> > >
> > > > >> > > David.
> > > > >> > >
> > > > >> > >
> > > > >> > >
> > > > >> > >
> > > > >> > >
> > > > >> >
> > > >
> > ---------------------------------------------------------------------
> > > > >> > > To unsubscribe, e-mail:
> > > > >> > user-unsubscribe@struts.apache.org
> > > > >> > > For additional commands,
> > e-mail:
> > > > >> > user-help@struts.apache.org
> > > > >> > >
> > > > >> > >
> > > > >> >
> > > > >> >
> > > >
> > ---------------------------------------------------------------------
> > > > >> > To unsubscribe, e-mail:
> > > > user-unsubscribe@struts.apache.org
> > > > >> > For additional commands, e-mail:
> > > > >> > user-help@struts.apache.org
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > > >>
> > > >
> > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail:
> > > > user-unsubscribe@struts.apache.org
> > > > >> For additional commands, e-mail:
> > > > user-help@struts.apache.org
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > > > --
> > > > > "Hey you! Would you help me to carry
> > the
> > > > stone?" Pink Floyd
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > "Hey you! Would you help me to carry the
> > stone?"
> > > > Pink Floyd
> > >
> > >
> > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > user-unsubscribe@struts.apache.org
> > > For additional commands, e-mail:
> > user-help@struts.apache.org
> > >
> > >
> >
> >
> > --
> > "Hey you! Would you help me to carry the stone?"
> > Pink Floyd
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>


-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by David Harland <ha...@yahoo.com>.
I know the feeling ;0)

Dave.


--- On Tue, 10/28/08, Musachy Barroso <mu...@gmail.com> wrote:

> From: Musachy Barroso <mu...@gmail.com>
> Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> To: "Struts Users Mailing List" <us...@struts.apache.org>, harlander3000@yahoo.com
> Date: Tuesday, October 28, 2008, 3:44 PM
> Attention Deficit Disorder + Multi-tasking = bad emails
> 
> :)
> 
> musachy
> 
> On Tue, Oct 28, 2008 at 10:35 AM, David Harland
> <ha...@yahoo.com>wrote:
> 
> > 2.0.11.1 works. 2.0.12 does not.
> >
> > Regards
> >
> > Dave
> >
> >
> > --- On Tue, 10/28/08, Musachy Barroso
> <mu...@gmail.com> wrote:
> >
> > > From: Musachy Barroso <mu...@gmail.com>
> > > Subject: Re: Struts 2.0.12 has broken Conversion
> Errors!!!
> > > To: "Struts Users Mailing List"
> <us...@struts.apache.org>,
> > harlander3000@yahoo.com
> > > Date: Tuesday, October 28, 2008, 3:32 PM
> > > Are you sure abut this? I am running 2.0.11.1 on
> the test
> > > case that you
> > > mentioned, and the conversion errors are added to
> the
> > > "fieldErrors" map on
> > > the action. Please note that the action must
> implement
> > > ValidationAware,
> > > otherwise the errors will do get lost.
> > >
> > > musachy
> > >
> > > On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso
> > > <mu...@gmail.com> wrote:
> > >
> > > > Thanks for reporting, I will look into it.
> > > >
> > > > musachy
> > > >
> > > >
> > > > On Tue, Oct 28, 2008 at 6:55 AM, David
> Harland
> > > <ha...@yahoo.com>wrote:
> > > >
> > > >> Done.
> > > >>
> > > >> Thanks
> > > >>
> > > >>
> > > >> --- On Tue, 10/28/08, Nils-Helge Garli
> Hegvik
> > > <ni...@gmail.com> wrote:
> > > >>
> > > >> > From: Nils-Helge Garli Hegvik
> > > <ni...@gmail.com>
> > > >> > Subject: Re: Struts 2.0.12 has
> broken
> > > Conversion Errors!!!
> > > >> > To: "Struts Users Mailing
> List"
> > > <us...@struts.apache.org>,
> > > >> harlander3000@yahoo.com
> > > >> > Date: Tuesday, October 28, 2008,
> 11:49 AM
> > > >> > Hi!
> > > >> >
> > > >> > If you have found a bug, please
> register an
> > > issue in JIRA
> > > >> > and include
> > > >> > as much relevant information as
> possible.
> > > >> >
> > > >> >
> http://struts.apache.org/helping.html#issues
> > > >> >
> > > >> > Thanks.
> > > >> >
> > > >> > Nils-H
> > > >> >
> > > >> > On Tue, Oct 28, 2008 at 11:34 AM,
> David
> > > Harland
> > > >> > <ha...@yahoo.com>
> wrote:
> > > >> > > Since upgrading to struts
> 2.0.12 from
> > > 2.0.11.1 all
> > > >> > conversion errors are being lost.
> > > >> > >
> > > >> > > Here is a simple example
> showing this is
> > > broken!
> > > >> > >
> > > >> > > Take the Struts2 blank app for
> 2.0.11.1.
> > > Now add a
> > > >> > simple Action with an Integer
> property
> > > testNumber. Now add a
> > > >> > jsp with a field testNumber. Now
> put fred in
> > > testNumber and
> > > >> > submit.
> > > >> > >
> > > >> > > You get 'Invalid field
> value for
> > > field
> > > >> > "testNumber".'
> > > >> > >
> > > >> > > Now replace the lib files from
> the
> > > 2.0.11.1 struts2
> > > >> > blank with the 2.0.12.
> > > >> > >
> > > >> > > The Conversion errors now do
> not get
> > > displayed. They
> > > >> > are lost!
> > > >> > >
> > > >> > > It appears to be the
> > > ParametersInterceptor is taking a
> > > >> > copy of the ValueStack, the
> conversion errors
> > > are being set
> > > >> > on the new stack and therefore
> lost.
> > > >> > >
> > > >> > > Regards
> > > >> > >
> > > >> > > David.
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> >
> > >
> ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail:
> > > >> > user-unsubscribe@struts.apache.org
> > > >> > > For additional commands,
> e-mail:
> > > >> > user-help@struts.apache.org
> > > >> > >
> > > >> > >
> > > >> >
> > > >> >
> > >
> ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail:
> > > user-unsubscribe@struts.apache.org
> > > >> > For additional commands, e-mail:
> > > >> > user-help@struts.apache.org
> > > >>
> > > >>
> > > >>
> > > >>
> > > >>
> > >
> ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail:
> > > user-unsubscribe@struts.apache.org
> > > >> For additional commands, e-mail:
> > > user-help@struts.apache.org
> > > >>
> > > >>
> > > >
> > > >
> > > > --
> > > > "Hey you! Would you help me to carry
> the
> > > stone?" Pink Floyd
> > > >
> > >
> > >
> > >
> > > --
> > > "Hey you! Would you help me to carry the
> stone?"
> > > Pink Floyd
> >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> user-unsubscribe@struts.apache.org
> > For additional commands, e-mail:
> user-help@struts.apache.org
> >
> >
> 
> 
> -- 
> "Hey you! Would you help me to carry the stone?"
> Pink Floyd


      

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Musachy Barroso <mu...@gmail.com>.
Attention Deficit Disorder + Multi-tasking = bad emails

:)

musachy

On Tue, Oct 28, 2008 at 10:35 AM, David Harland <ha...@yahoo.com>wrote:

> 2.0.11.1 works. 2.0.12 does not.
>
> Regards
>
> Dave
>
>
> --- On Tue, 10/28/08, Musachy Barroso <mu...@gmail.com> wrote:
>
> > From: Musachy Barroso <mu...@gmail.com>
> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> > To: "Struts Users Mailing List" <us...@struts.apache.org>,
> harlander3000@yahoo.com
> > Date: Tuesday, October 28, 2008, 3:32 PM
> > Are you sure abut this? I am running 2.0.11.1 on the test
> > case that you
> > mentioned, and the conversion errors are added to the
> > "fieldErrors" map on
> > the action. Please note that the action must implement
> > ValidationAware,
> > otherwise the errors will do get lost.
> >
> > musachy
> >
> > On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso
> > <mu...@gmail.com> wrote:
> >
> > > Thanks for reporting, I will look into it.
> > >
> > > musachy
> > >
> > >
> > > On Tue, Oct 28, 2008 at 6:55 AM, David Harland
> > <ha...@yahoo.com>wrote:
> > >
> > >> Done.
> > >>
> > >> Thanks
> > >>
> > >>
> > >> --- On Tue, 10/28/08, Nils-Helge Garli Hegvik
> > <ni...@gmail.com> wrote:
> > >>
> > >> > From: Nils-Helge Garli Hegvik
> > <ni...@gmail.com>
> > >> > Subject: Re: Struts 2.0.12 has broken
> > Conversion Errors!!!
> > >> > To: "Struts Users Mailing List"
> > <us...@struts.apache.org>,
> > >> harlander3000@yahoo.com
> > >> > Date: Tuesday, October 28, 2008, 11:49 AM
> > >> > Hi!
> > >> >
> > >> > If you have found a bug, please register an
> > issue in JIRA
> > >> > and include
> > >> > as much relevant information as possible.
> > >> >
> > >> > http://struts.apache.org/helping.html#issues
> > >> >
> > >> > Thanks.
> > >> >
> > >> > Nils-H
> > >> >
> > >> > On Tue, Oct 28, 2008 at 11:34 AM, David
> > Harland
> > >> > <ha...@yahoo.com> wrote:
> > >> > > Since upgrading to struts 2.0.12 from
> > 2.0.11.1 all
> > >> > conversion errors are being lost.
> > >> > >
> > >> > > Here is a simple example showing this is
> > broken!
> > >> > >
> > >> > > Take the Struts2 blank app for 2.0.11.1.
> > Now add a
> > >> > simple Action with an Integer property
> > testNumber. Now add a
> > >> > jsp with a field testNumber. Now put fred in
> > testNumber and
> > >> > submit.
> > >> > >
> > >> > > You get 'Invalid field value for
> > field
> > >> > "testNumber".'
> > >> > >
> > >> > > Now replace the lib files from the
> > 2.0.11.1 struts2
> > >> > blank with the 2.0.12.
> > >> > >
> > >> > > The Conversion errors now do not get
> > displayed. They
> > >> > are lost!
> > >> > >
> > >> > > It appears to be the
> > ParametersInterceptor is taking a
> > >> > copy of the ValueStack, the conversion errors
> > are being set
> > >> > on the new stack and therefore lost.
> > >> > >
> > >> > > Regards
> > >> > >
> > >> > > David.
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> >
> > ---------------------------------------------------------------------
> > >> > > To unsubscribe, e-mail:
> > >> > user-unsubscribe@struts.apache.org
> > >> > > For additional commands, e-mail:
> > >> > user-help@struts.apache.org
> > >> > >
> > >> > >
> > >> >
> > >> >
> > ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail:
> > user-unsubscribe@struts.apache.org
> > >> > For additional commands, e-mail:
> > >> > user-help@struts.apache.org
> > >>
> > >>
> > >>
> > >>
> > >>
> > ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> > user-unsubscribe@struts.apache.org
> > >> For additional commands, e-mail:
> > user-help@struts.apache.org
> > >>
> > >>
> > >
> > >
> > > --
> > > "Hey you! Would you help me to carry the
> > stone?" Pink Floyd
> > >
> >
> >
> >
> > --
> > "Hey you! Would you help me to carry the stone?"
> > Pink Floyd
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>


-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by David Harland <ha...@yahoo.com>.
2.0.11.1 works. 2.0.12 does not.

Regards

Dave


--- On Tue, 10/28/08, Musachy Barroso <mu...@gmail.com> wrote:

> From: Musachy Barroso <mu...@gmail.com>
> Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> To: "Struts Users Mailing List" <us...@struts.apache.org>, harlander3000@yahoo.com
> Date: Tuesday, October 28, 2008, 3:32 PM
> Are you sure abut this? I am running 2.0.11.1 on the test
> case that you
> mentioned, and the conversion errors are added to the
> "fieldErrors" map on
> the action. Please note that the action must implement
> ValidationAware,
> otherwise the errors will do get lost.
> 
> musachy
> 
> On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso
> <mu...@gmail.com> wrote:
> 
> > Thanks for reporting, I will look into it.
> >
> > musachy
> >
> >
> > On Tue, Oct 28, 2008 at 6:55 AM, David Harland
> <ha...@yahoo.com>wrote:
> >
> >> Done.
> >>
> >> Thanks
> >>
> >>
> >> --- On Tue, 10/28/08, Nils-Helge Garli Hegvik
> <ni...@gmail.com> wrote:
> >>
> >> > From: Nils-Helge Garli Hegvik
> <ni...@gmail.com>
> >> > Subject: Re: Struts 2.0.12 has broken
> Conversion Errors!!!
> >> > To: "Struts Users Mailing List"
> <us...@struts.apache.org>,
> >> harlander3000@yahoo.com
> >> > Date: Tuesday, October 28, 2008, 11:49 AM
> >> > Hi!
> >> >
> >> > If you have found a bug, please register an
> issue in JIRA
> >> > and include
> >> > as much relevant information as possible.
> >> >
> >> > http://struts.apache.org/helping.html#issues
> >> >
> >> > Thanks.
> >> >
> >> > Nils-H
> >> >
> >> > On Tue, Oct 28, 2008 at 11:34 AM, David
> Harland
> >> > <ha...@yahoo.com> wrote:
> >> > > Since upgrading to struts 2.0.12 from
> 2.0.11.1 all
> >> > conversion errors are being lost.
> >> > >
> >> > > Here is a simple example showing this is
> broken!
> >> > >
> >> > > Take the Struts2 blank app for 2.0.11.1.
> Now add a
> >> > simple Action with an Integer property
> testNumber. Now add a
> >> > jsp with a field testNumber. Now put fred in
> testNumber and
> >> > submit.
> >> > >
> >> > > You get 'Invalid field value for
> field
> >> > "testNumber".'
> >> > >
> >> > > Now replace the lib files from the
> 2.0.11.1 struts2
> >> > blank with the 2.0.12.
> >> > >
> >> > > The Conversion errors now do not get
> displayed. They
> >> > are lost!
> >> > >
> >> > > It appears to be the
> ParametersInterceptor is taking a
> >> > copy of the ValueStack, the conversion errors
> are being set
> >> > on the new stack and therefore lost.
> >> > >
> >> > > Regards
> >> > >
> >> > > David.
> >> > >
> >> > >
> >> > >
> >> > >
> >> > >
> >> >
> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail:
> >> > user-unsubscribe@struts.apache.org
> >> > > For additional commands, e-mail:
> >> > user-help@struts.apache.org
> >> > >
> >> > >
> >> >
> >> >
> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail:
> user-unsubscribe@struts.apache.org
> >> > For additional commands, e-mail:
> >> > user-help@struts.apache.org
> >>
> >>
> >>
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail:
> user-unsubscribe@struts.apache.org
> >> For additional commands, e-mail:
> user-help@struts.apache.org
> >>
> >>
> >
> >
> > --
> > "Hey you! Would you help me to carry the
> stone?" Pink Floyd
> >
> 
> 
> 
> -- 
> "Hey you! Would you help me to carry the stone?"
> Pink Floyd


      

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Musachy Barroso <mu...@gmail.com>.
Are you sure abut this? I am running 2.0.11.1 on the test case that you
mentioned, and the conversion errors are added to the "fieldErrors" map on
the action. Please note that the action must implement ValidationAware,
otherwise the errors will do get lost.

musachy

On Tue, Oct 28, 2008 at 9:27 AM, Musachy Barroso <mu...@gmail.com> wrote:

> Thanks for reporting, I will look into it.
>
> musachy
>
>
> On Tue, Oct 28, 2008 at 6:55 AM, David Harland <ha...@yahoo.com>wrote:
>
>> Done.
>>
>> Thanks
>>
>>
>> --- On Tue, 10/28/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
>>
>> > From: Nils-Helge Garli Hegvik <ni...@gmail.com>
>> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
>> > To: "Struts Users Mailing List" <us...@struts.apache.org>,
>> harlander3000@yahoo.com
>> > Date: Tuesday, October 28, 2008, 11:49 AM
>> > Hi!
>> >
>> > If you have found a bug, please register an issue in JIRA
>> > and include
>> > as much relevant information as possible.
>> >
>> > http://struts.apache.org/helping.html#issues
>> >
>> > Thanks.
>> >
>> > Nils-H
>> >
>> > On Tue, Oct 28, 2008 at 11:34 AM, David Harland
>> > <ha...@yahoo.com> wrote:
>> > > Since upgrading to struts 2.0.12 from 2.0.11.1 all
>> > conversion errors are being lost.
>> > >
>> > > Here is a simple example showing this is broken!
>> > >
>> > > Take the Struts2 blank app for 2.0.11.1. Now add a
>> > simple Action with an Integer property testNumber. Now add a
>> > jsp with a field testNumber. Now put fred in testNumber and
>> > submit.
>> > >
>> > > You get 'Invalid field value for field
>> > "testNumber".'
>> > >
>> > > Now replace the lib files from the 2.0.11.1 struts2
>> > blank with the 2.0.12.
>> > >
>> > > The Conversion errors now do not get displayed. They
>> > are lost!
>> > >
>> > > It appears to be the ParametersInterceptor is taking a
>> > copy of the ValueStack, the conversion errors are being set
>> > on the new stack and therefore lost.
>> > >
>> > > Regards
>> > >
>> > > David.
>> > >
>> > >
>> > >
>> > >
>> > >
>> > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail:
>> > user-unsubscribe@struts.apache.org
>> > > For additional commands, e-mail:
>> > user-help@struts.apache.org
>> > >
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> > For additional commands, e-mail:
>> > user-help@struts.apache.org
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
>> For additional commands, e-mail: user-help@struts.apache.org
>>
>>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>



-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Musachy Barroso <mu...@gmail.com>.
Thanks for reporting, I will look into it.

musachy

On Tue, Oct 28, 2008 at 6:55 AM, David Harland <ha...@yahoo.com>wrote:

> Done.
>
> Thanks
>
>
> --- On Tue, 10/28/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:
>
> > From: Nils-Helge Garli Hegvik <ni...@gmail.com>
> > Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> > To: "Struts Users Mailing List" <us...@struts.apache.org>,
> harlander3000@yahoo.com
> > Date: Tuesday, October 28, 2008, 11:49 AM
> > Hi!
> >
> > If you have found a bug, please register an issue in JIRA
> > and include
> > as much relevant information as possible.
> >
> > http://struts.apache.org/helping.html#issues
> >
> > Thanks.
> >
> > Nils-H
> >
> > On Tue, Oct 28, 2008 at 11:34 AM, David Harland
> > <ha...@yahoo.com> wrote:
> > > Since upgrading to struts 2.0.12 from 2.0.11.1 all
> > conversion errors are being lost.
> > >
> > > Here is a simple example showing this is broken!
> > >
> > > Take the Struts2 blank app for 2.0.11.1. Now add a
> > simple Action with an Integer property testNumber. Now add a
> > jsp with a field testNumber. Now put fred in testNumber and
> > submit.
> > >
> > > You get 'Invalid field value for field
> > "testNumber".'
> > >
> > > Now replace the lib files from the 2.0.11.1 struts2
> > blank with the 2.0.12.
> > >
> > > The Conversion errors now do not get displayed. They
> > are lost!
> > >
> > > It appears to be the ParametersInterceptor is taking a
> > copy of the ValueStack, the conversion errors are being set
> > on the new stack and therefore lost.
> > >
> > > Regards
> > >
> > > David.
> > >
> > >
> > >
> > >
> > >
> > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > user-unsubscribe@struts.apache.org
> > > For additional commands, e-mail:
> > user-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> > For additional commands, e-mail:
> > user-help@struts.apache.org
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>


-- 
"Hey you! Would you help me to carry the stone?" Pink Floyd

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by David Harland <ha...@yahoo.com>.
Done.

Thanks


--- On Tue, 10/28/08, Nils-Helge Garli Hegvik <ni...@gmail.com> wrote:

> From: Nils-Helge Garli Hegvik <ni...@gmail.com>
> Subject: Re: Struts 2.0.12 has broken Conversion Errors!!!
> To: "Struts Users Mailing List" <us...@struts.apache.org>, harlander3000@yahoo.com
> Date: Tuesday, October 28, 2008, 11:49 AM
> Hi!
> 
> If you have found a bug, please register an issue in JIRA
> and include
> as much relevant information as possible.
> 
> http://struts.apache.org/helping.html#issues
> 
> Thanks.
> 
> Nils-H
> 
> On Tue, Oct 28, 2008 at 11:34 AM, David Harland
> <ha...@yahoo.com> wrote:
> > Since upgrading to struts 2.0.12 from 2.0.11.1 all
> conversion errors are being lost.
> >
> > Here is a simple example showing this is broken!
> >
> > Take the Struts2 blank app for 2.0.11.1. Now add a
> simple Action with an Integer property testNumber. Now add a
> jsp with a field testNumber. Now put fred in testNumber and
> submit.
> >
> > You get 'Invalid field value for field
> "testNumber".'
> >
> > Now replace the lib files from the 2.0.11.1 struts2
> blank with the 2.0.12.
> >
> > The Conversion errors now do not get displayed. They
> are lost!
> >
> > It appears to be the ParametersInterceptor is taking a
> copy of the ValueStack, the conversion errors are being set
> on the new stack and therefore lost.
> >
> > Regards
> >
> > David.
> >
> >
> >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> user-unsubscribe@struts.apache.org
> > For additional commands, e-mail:
> user-help@struts.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail:
> user-help@struts.apache.org


      

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org

Re: Struts 2.0.12 has broken Conversion Errors!!!

Posted by Nils-Helge Garli Hegvik <ni...@gmail.com>.
Hi!

If you have found a bug, please register an issue in JIRA and include
as much relevant information as possible.

http://struts.apache.org/helping.html#issues

Thanks.

Nils-H

On Tue, Oct 28, 2008 at 11:34 AM, David Harland <ha...@yahoo.com> wrote:
> Since upgrading to struts 2.0.12 from 2.0.11.1 all conversion errors are being lost.
>
> Here is a simple example showing this is broken!
>
> Take the Struts2 blank app for 2.0.11.1. Now add a simple Action with an Integer property testNumber. Now add a jsp with a field testNumber. Now put fred in testNumber and submit.
>
> You get 'Invalid field value for field "testNumber".'
>
> Now replace the lib files from the 2.0.11.1 struts2 blank with the 2.0.12.
>
> The Conversion errors now do not get displayed. They are lost!
>
> It appears to be the ParametersInterceptor is taking a copy of the ValueStack, the conversion errors are being set on the new stack and therefore lost.
>
> Regards
>
> David.
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org