You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/07/07 16:19:09 UTC

[whimsy] branch master updated: Unnecessary variable

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 814cbd1  Unnecessary variable
814cbd1 is described below

commit 814cbd1a678d1ce5b7b29094a6380471af673de8
Author: Sebb <se...@apache.org>
AuthorDate: Tue Jul 7 17:19:00 2020 +0100

    Unnecessary variable
---
 lib/whimsy/asf/icla.rb | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/whimsy/asf/icla.rb b/lib/whimsy/asf/icla.rb
index b14864a..c1a46f0 100644
--- a/lib/whimsy/asf/icla.rb
+++ b/lib/whimsy/asf/icla.rb
@@ -212,8 +212,7 @@ module ASF
     # list of reserved availids
     def self.availids_reserved
       return @@availids_reserved if @@availids_reserved
-      archive = ASF::SVN['officers']
-      reserved = File.read(File.join(archive, 'reserved-ids.yml')).scan(/^- (\S+)/).flatten.uniq
+      reserved = File.read(File.join(ASF::SVN['officers'], 'reserved-ids.yml')).scan(/^- (\S+)/).flatten.uniq
       # Add in badrcptto
       reserved += self.badmails
       @@availids_reserved = reserved.uniq
@@ -265,8 +264,7 @@ module ASF
   # but never submitted an ICLA (some of which are still ASF members or
   # members of a PMC).
   def self.search_archive_by_id(id)
-    archive = ASF::SVN['officers_historic']
-    name = JSON.parse(File.read(File.join(archive, 'committers.json')))[id]
+    name = JSON.parse(File.read(File.join(ASF::SVN['officers_historic'], 'committers.json')))[id]
     name = id if name and name.empty?
     name
   end