You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/19 22:20:30 UTC

[GitHub] [incubator-druid] jon-wei opened a new pull request #8341: Add logging for LZ4Factory instance type

jon-wei opened a new pull request #8341: Add logging for LZ4Factory instance type
URL: https://github.com/apache/incubator-druid/pull/8341
 
 
   The `LZ4Factory` instance used for compression can have three different implementations:
   - native
   - unsafe
   - safe
   
   The implementation used can affect the size of compressed output, so this PR adds additional logging around the LZ4 library to show what instance is being used. The value of `java.library.path` is also logged, since the native instance depends on `libc` > 2.14 being available on that path.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] been tested in a test Druid cluster.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org