You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/08/10 02:48:59 UTC
[GitHub] incubator-beam pull request #806: [BEAM-498] Remove WindowingInternals suppo...
GitHub user kennknowles opened a pull request:
https://github.com/apache/incubator-beam/pull/806
[BEAM-498] Remove WindowingInternals support from DoFnReflector
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This removal prevents any use of this extra parameter, since it is not supported. When we have new generics supported, we will want to revive many of the tests which are general tests for handling of type parameters.
R: @bjchambers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/incubator-beam DoFn-WindowingInternals
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #806
----
commit 7a317b76e7b1757dab3777b3376a8f8787b21cf7
Author: Kenneth Knowles <kl...@google.com>
Date: 2016-08-10T02:46:01Z
Remove WindowingInternals support from DoFnReflector
This removal prevents any use of this extra parameter, since
it is not supported. When we have new generics supported, we
will want to revive many of the tests which are general tests
for handling of type parameters.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #806: [BEAM-498] Remove WindowingInternals suppo...
Posted by kennknowles <gi...@git.apache.org>.
Github user kennknowles closed the pull request at:
https://github.com/apache/incubator-beam/pull/806
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---