You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "quic-sanirudh (via GitHub)" <gi...@apache.org> on 2023/04/25 11:27:05 UTC

[GitHub] [tvm] quic-sanirudh opened a new pull request, #14720: [TIR] [Hexagon] Add get_vtcm_allocation_sizes with lowering

quic-sanirudh opened a new pull request, #14720:
URL: https://github.com/apache/tvm/pull/14720

   This patch adds an utility function for getting the VTCM sizes allocated in an IRModule. In order to do that, we've exposed the list of lowering passes to python and we've refactored the PostprocVerifyVTCMLimit to be computed for whole module and the same list of lowering passes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #14720: [TIR] [Hexagon] Add get_vtcm_allocation_sizes with lowering

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14720:
URL: https://github.com/apache/tvm/pull/14720#issuecomment-1521628069

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @ibsidorenko, @junrushao, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi commented on a diff in pull request #14720: [TIR] [Hexagon] Add get_vtcm_allocation_sizes with lowering

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on code in PR #14720:
URL: https://github.com/apache/tvm/pull/14720#discussion_r1177201458


##########
python/tvm/tir/analysis/analysis.py:
##########
@@ -384,3 +385,15 @@ def find_anchor_block(mod: IRModule) -> Block:
         The anchor block if found, None otherwise.
     """
     return _ffi_api.find_anchor_block(mod)  # type: ignore # pylint: disable=no-member
+
+
+def get_vtcm_compaction_passes() -> List[tvm.transform.Pass]:
+    """Utility function to get the list of lowering passes to be applied to calculate thecompacted

Review Comment:
   Please fix the typo `thecompacted` later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] quic-sanirudh commented on pull request #14720: [TIR] [Hexagon] Add get_vtcm_allocation_sizes with lowering

Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh commented on PR #14720:
URL: https://github.com/apache/tvm/pull/14720#issuecomment-1521629946

   cc @masahi @Icemist 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] masahi merged pull request #14720: [TIR] [Hexagon] Add get_vtcm_allocation_sizes with lowering

Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi merged PR #14720:
URL: https://github.com/apache/tvm/pull/14720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org