You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Brian Femiano (JIRA)" <ji...@apache.org> on 2012/09/27 17:12:07 UTC
[jira] [Commented] (GIRAPH-349) Giraph Formats Tests broken
[ https://issues.apache.org/jira/browse/GIRAPH-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464806#comment-13464806 ]
Brian Femiano commented on GIRAPH-349:
--------------------------------------
I fixed this temporarily in my patch for Giraph-336 by adding the same {forHadoop} property in formats that mirrors the
main giraph pom.
The issue is that this is technically not a child project to the giraph main pom, and thus can't directly inherit it's properties.
Having a base parent-pom in the trunk would probably solve this.
> Giraph Formats Tests broken
> ---------------------------
>
> Key: GIRAPH-349
> URL: https://issues.apache.org/jira/browse/GIRAPH-349
> Project: Giraph
> Issue Type: Bug
> Reporter: Nitay Joffe
> Assignee: Eli Reisman
>
> GIRAPH-209 broke giraph-formats-contrib tests because of the prop.jarLocation change.
> In giraph-formats-contrib/pom.xml we have prop.jarLocation set as:
> <property>
> <name>prop.jarLocation</name>
> <value>${giraph.trunk.base}/target/giraph-${project.version}-jar-with-dependencies.jar</value>
> </property>
> The problem is I don't see how to easily get the hadoop version (until maybe we have the parent pom which can hold the version for everyone to use). Eli, assigning this to you for your thoughts.
> Note that when I changed this value by hand to ${giraph.trunk.base}/target/giraph-${project.version}-for-hadoop-0.20.203.0-jar-with-dependencies.jar the tests run. Something is still failing but it is a completely different reason, not because of System.getProperty("prop.jarLocation") problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira