You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/07 22:48:27 UTC

[GitHub] [superset] codecov-io commented on pull request #12993: feat(dashboard_rbac): roles api for fetching roles and filtering by name

codecov-io commented on pull request #12993:
URL: https://github.com/apache/superset/pull/12993#issuecomment-774782353


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=h1) Report
   > Merging [#12993](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=desc) (3017074) into [master](https://codecov.io/gh/apache/superset/commit/8ccf2e8f1e33a95c03b9d391068f615efa22570e?el=desc) (8ccf2e8) will **increase** coverage by `18.79%`.
   > The diff coverage is `97.22%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12993/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12993       +/-   ##
   ===========================================
   + Coverage   48.18%   66.98%   +18.79%     
   ===========================================
     Files         480      491       +11     
     Lines       17315    28764    +11449     
     Branches     4485        0     -4485     
   ===========================================
   + Hits         8344    19267    +10923     
   - Misses       8971     9497      +526     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | python | `66.98% <97.22%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/roles/filters.py](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcm9sZXMvZmlsdGVycy5weQ==) | `93.33% <93.33%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.49% <100.00%> (ø)` | |
   | [superset/roles/api.py](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcm9sZXMvYXBpLnB5) | `100.00% <100.00%> (ø)` | |
   | [...-frontend/src/dashboard/containers/FilterScope.jsx](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0ZpbHRlclNjb3BlLmpzeA==) | | |
   | [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | | |
   | [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | | |
   | [superset-frontend/src/middleware/asyncEvent.ts](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21pZGRsZXdhcmUvYXN5bmNFdmVudC50cw==) | | |
   | [...perset-frontend/src/common/components/Dropdown.tsx](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0Ryb3Bkb3duLnRzeA==) | | |
   | [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | | |
   | [...set-frontend/src/dashboard/util/resizableConfig.ts](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Jlc2l6YWJsZUNvbmZpZy50cw==) | | |
   | ... and [964 more](https://codecov.io/gh/apache/superset/pull/12993/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=footer). Last update [8ccf2e8...7b11028](https://codecov.io/gh/apache/superset/pull/12993?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org