You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/16 16:54:07 UTC
[GitHub] [netbeans] DevCharly opened a new pull request, #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
DevCharly opened a new pull request, #5298:
URL: https://github.com/apache/netbeans/pull/5298
Update FlatLaf to v3.0.
Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/3.0
### macOS themes
FlatLaf 3 comes with two new themes, which look similar to macOS:
I've added both to the list of look and feels (on all platforms, screenshots are from Windows 11):
### Rounded outlined icons
FlatLaf 3 has new modern rounded outlined icons for `JFileChooser`, `JOptionPane`, `JPasswordField` and `JTree`:
They are e.g. used in project/file trees and in file choosers (in all FlatLaf themes):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1387443938
@mbien to be clear, my main concern is that it's an Apple trademark. While we reference it elsewhere, it's always a direct reference to Apple products, rather than something designed to look similar, as far as I can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1396066200
>One concern would be whether we should be using the name macOS in the UI here? Maybe something like FlatLaf Cupertino Light?
Good idea 👍
I'm fine with Cupertino
> Are the mentioned fonts included in this change for NetBeans?
No. They are in extra JARs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1399304704
I tested this patch in its current form on my private NetBeans build; works as expected with no problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1384529065
> I like the new icons.
Thx 😄
> The dark mac theme might be interesting for those who prefer higher contrast themes.
Yes, definitely. That's why I've not limited those themes to mac platform 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1387456784
@neilcsmith-net yes mine too. I already looked up bug species which like apples but they all have fairly complicated names :)
I only wanted to bring up a technical reason why naming it after an OS might not be a good idea. If it would start diverging from the mac look it might be perceived as a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1387248315
Looks great! I was somewhat tempted to squeeze it in just before I branched, although hadn't had a chance to look properly so didn't want to make the call. :smile:
One concern would be whether we should be using the name `macOS` in the UI here? Maybe something like `FlatLaf Cupertino Light`?
Are the mentioned fonts included in this change for NetBeans?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1384537027
@DevCharly its off topic but since I see it in the screenshots. I feel like I am missing out on those nice shortcut buttons on the left side of the file chooser dialog as linux user :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "DevCharly (via GitHub)" <gi...@apache.org>.
DevCharly commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1399640097
I've renamed the new themes to Cupertino.
Please let me know if there is a need to rebase this PR to `delivery`.
But since the branch for this PR was created before the `delivery` branch was created, there is actually no need to rebase it.
It can be merged directly into the `delivery` branch. Rebasing makes no difference...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1399309181
if the `Cupertino` renaming makes it in time before RC2 we should rebase this PR on `delivery` and get this in for NB 17 in my opinion.
This is technically a bugfix since it removes 8 superfluous pixels on the file open dialog I _totally_ noticed while working with NB 16 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "Chris2011 (via GitHub)" <gi...@apache.org>.
Chris2011 commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1454872338
Great icons, but is it possible, that I can change it via the flatlaf properties file? I don't like this mixed stuff what we have. Most of the NetBeans Icons are not outlined and now it looks a bit odd with those all not outlined Icons in the Project window with the just folder outlined ones. As long as we can't switch all icons to either outline or not, I would like to change them by my own. Is this easy possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "DevCharly (via GitHub)" <gi...@apache.org>.
DevCharly commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1493054327
@Chris2011 yes, this really looks odd.
Have created PR #5760 to replace FlatLaf outlined folder icons with NetBeans style icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1387423878
> One concern would be whether we should be using the name macOS in the UI here? Maybe something like FlatLaf Cupertino Light?
agreed. Mac OS is also changing the theme periodically, so it would be better the not associate a Look and Feel with a OS theme to have more flexibility if it needs adjustments. I like Cupertino since it still alludes to the origin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #5298:
URL: https://github.com/apache/netbeans/pull/5298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #5298: Update FlatLaf from 2.6 to 3.0 and add macOS light and dark themes
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #5298:
URL: https://github.com/apache/netbeans/pull/5298#issuecomment-1387746367
> @DevCharly its off topic but since I see it in the screenshots. I feel like I am missing out on those nice shortcut buttons on the left side of the file chooser dialog as linux user :)
Yes, unfortunately the shortcuts are only available on Windows because the used Java API provides the information only on Windows 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists