You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/01 06:51:11 UTC
Re: Review Request 33838: LENS-484 : NPE when weight is not set in
XFactTable object while creating fact table
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33838/#review85929
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On May 22, 2015, 12:01 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33838/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 12:01 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> NPE when weight is not set in XFactTable object while creating fact table
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 1e8d71d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 19979cc
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java PRE-CREATION
> lens-cli/src/test/resources/cube_with_no_weight_facts.xml PRE-CREATION
> lens-cli/src/test/resources/dim-local-storage-element.xml 5a19cfa
> lens-cli/src/test/resources/dim_table.xml 932c975
> lens-cli/src/test/resources/dim_table2.xml 1d6e138
> lens-cli/src/test/resources/fact-local-storage-element.xml 8ec3b42
> lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION
> lens-cli/src/test/resources/sample-cube.xml d54bcfb
> lens-cli/src/test/resources/test-dimension.xml d602569
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java a6651f6
> lens-examples/src/main/resources/city_subset.xml 5059e5e
> lens-examples/src/main/resources/customer_table.xml 18c387f
> lens-examples/src/main/resources/dim_table.xml 25367af
> lens-examples/src/main/resources/dim_table2.xml eef1513
> lens-examples/src/main/resources/dim_table3.xml 386c394
> lens-examples/src/main/resources/dim_table4.xml 69e3c50
> lens-examples/src/main/resources/product_db_table.xml d961c44
> lens-examples/src/main/resources/product_table.xml 86a1115
> lens-examples/src/main/resources/sales-aggr-fact1.xml 073052d
> lens-examples/src/main/resources/sales-aggr-fact2.xml 67b7171
> lens-examples/src/main/resources/sales-cube.xml e44141c
> lens-examples/src/main/resources/sample-cube.xml 0d97842
>
> Diff: https://reviews.apache.org/r/33838/diff/
>
>
> Testing
> -------
>
> Yes.
> TestCase:
> mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands
>
>
> Thanks,
>
> Yash Sharma
>
>