[GitHub] [hbase] taklwu commented on a change in pull request #3902: HBASE-26524 Support remove coprocessor by class name via alter table …

[GitBox <gi...@apache.org>]

taklwu commented on a change in pull request #3902:
URL: https://github.com/apache/hbase/pull/3902#discussion_r760381014



##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -824,6 +824,17 @@ def alter(table_name_str, wait = true, *args)
               tdb.removeValue(name)
             end
             hasTableUpdate = true
+          elsif method == 'table_remove_coprocessor'
+            classname = arg.delete(CLASSNAME)
+            raise(ArgumentError, 'CLASSNAME parameter missing for table_remove_coprocessor method') unless classname

Review comment:
       I would prefer to keep using classname without plural form, basically, I'm following the convention of this file and other place if they're defined as array are using single form. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org