You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by yo...@apache.org on 2010/10/15 02:40:56 UTC

svn commit: r1022788 - /lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java

Author: yonik
Date: Fri Oct 15 00:40:56 2010
New Revision: 1022788

URL: http://svn.apache.org/viewvc?rev=1022788&view=rev
Log:
tests: fix resource leak

Modified:
    lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java

Modified: lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java?rev=1022788&r1=1022787&r2=1022788&view=diff
==============================================================================
--- lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java (original)
+++ lucene/dev/trunk/solr/contrib/extraction/src/test/java/org/apache/solr/handler/ExtractingRequestHandlerTest.java Fri Oct 15 00:40:56 2010
@@ -355,13 +355,16 @@ public class ExtractingRequestHandlerTes
 
   SolrQueryResponse loadLocal(String filename, String... args) throws Exception {
     LocalSolrQueryRequest req = (LocalSolrQueryRequest) req(args);
-
-    // TODO: stop using locally defined streams once stream.file and
-    // stream.body work everywhere
-    List<ContentStream> cs = new ArrayList<ContentStream>();
-    cs.add(new ContentStreamBase.FileStream(new File(filename)));
-    req.setContentStreams(cs);
-    return h.queryAndResponse("/update/extract", req);
+    try {
+      // TODO: stop using locally defined streams once stream.file and
+      // stream.body work everywhere
+      List<ContentStream> cs = new ArrayList<ContentStream>();
+      cs.add(new ContentStreamBase.FileStream(new File(filename)));
+      req.setContentStreams(cs);
+      return h.queryAndResponse("/update/extract", req);
+    } finally {
+      req.close();
+    }
   }