[GitHub] [cassandra] yifan-c commented on a change in pull request #749: CASSANDRA-16057: Should update in-jvm dtest to expose stdout and stderr for nodetool

[GitBox <gi...@apache.org>]

yifan-c commented on a change in pull request #749:
URL: https://github.com/apache/cassandra/pull/749#discussion_r486707867



##########
File path: src/java/org/apache/cassandra/tools/NodeTool.java
##########
@@ -405,10 +415,12 @@ private NodeProbe connect()
                     nodeClient = nodeProbeFactory.create(host, parseInt(port));
                 else
                     nodeClient = nodeProbeFactory.create(host, parseInt(port), username, password);
+
+                nodeClient.setConsoleOutputProvider(consoleOutputProvider);

Review comment:
       OK with either. I will update the create method then.  
   (mutate the ref, so the change is slightly less)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org