You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@twitter.com> on 2013/04/03 00:55:27 UTC
Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
This is the part 2.
Part 1: https://reviews.apache.org/r/10231/
This addresses bug MESOS-415.
https://issues.apache.org/jira/browse/MESOS-415
Diffs
-----
src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
Diff: https://reviews.apache.org/r/10241/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Ben Mahler <be...@gmail.com>.
> On April 3, 2013, 6:27 p.m., Vinod Kone wrote:
> > src/examples/balloon_executor.cpp, line 74
> > <https://reviews.apache.org/r/10241/diff/1/?file=277220#file277220line74>
> >
> > Do you want to check the return value to make sure it is not an error?
> >
> > Here and everywhere else.
>
> Jiang Yan Xu wrote:
> I feel that it dependents on the logic on the caller side. This revision replaced the API usage but probably should not change the semantics. The callers could have checked for the errors previously with the old API and if some of them need error-checking, it could be added selectively where it's appropriate.
I agree with Yan here, I think most of the time we can ignore os::sleep errors, like we ignored ::sleep errors.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18666
-----------------------------------------------------------
On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Jiang Yan Xu <ya...@twitter.com>.
> On April 3, 2013, 6:27 p.m., Vinod Kone wrote:
> > src/examples/balloon_executor.cpp, line 74
> > <https://reviews.apache.org/r/10241/diff/1/?file=277220#file277220line74>
> >
> > Do you want to check the return value to make sure it is not an error?
> >
> > Here and everywhere else.
I feel that it dependents on the logic on the caller side. This revision replaced the API usage but probably should not change the semantics. The callers could have checked for the errors previously with the old API and if some of them need error-checking, it could be added selectively where it's appropriate.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18666
-----------------------------------------------------------
On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18666
-----------------------------------------------------------
src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/10241/#comment39048>
Do you want to check the return value to make sure it is not an error?
Here and everywhere else.
- Vinod Kone
On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18905
-----------------------------------------------------------
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/10241/#comment39374>
revert the changes to this file?
third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/10241/#comment39375>
Milliseconds(10)?
third_party/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/10241/#comment39376>
ditto
third_party/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/10241/#comment39379>
ditto
third_party/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/10241/#comment39380>
ditto
- Ben Mahler
On April 9, 2013, 11:14 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 11:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 19b285b42dbdcf712511ab89b259b4d43dad3dfb
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced usleep() calls in libprocess with os::sleep()
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/
-----------------------------------------------------------
(Updated April 13, 2013, 7:55 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Separated out libprocess specific changes.
Summary (updated)
-----------------
Replaced usleep() calls in libprocess with os::sleep()
Description
-------
This is the part 2.
Part 1: https://reviews.apache.org/r/10231/
This addresses bug MESOS-415.
https://issues.apache.org/jira/browse/MESOS-415
Diffs (updated)
-----
third_party/libprocess/configure.ac cb7f0d73c6ddc1e75f7a3120858362c56a003aa7
third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
Diff: https://reviews.apache.org/r/10241/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18955
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 10, 2013, 6:03 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 10, 2013, 6:03 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 19b285b42dbdcf712511ab89b259b4d43dad3dfb
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/
-----------------------------------------------------------
(Updated April 10, 2013, 6:03 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Addressed bmahler's comments.
Description
-------
This is the part 2.
Part 1: https://reviews.apache.org/r/10231/
This addresses bug MESOS-415.
https://issues.apache.org/jira/browse/MESOS-415
Diffs (updated)
-----
src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
src/tests/utils.hpp 19b285b42dbdcf712511ab89b259b4d43dad3dfb
src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
Diff: https://reviews.apache.org/r/10241/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/
-----------------------------------------------------------
(Updated April 9, 2013, 11:14 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Removed a white space.
Description
-------
This is the part 2.
Part 1: https://reviews.apache.org/r/10231/
This addresses bug MESOS-415.
https://issues.apache.org/jira/browse/MESOS-415
Diffs (updated)
-----
src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
src/tests/utils.hpp 19b285b42dbdcf712511ab89b259b4d43dad3dfb
src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
Diff: https://reviews.apache.org/r/10241/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/
-----------------------------------------------------------
(Updated April 9, 2013, 10:36 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Some changes were dropped because the sleep() calls were dropped in the trunk in recent fixes.
Description
-------
This is the part 2.
Part 1: https://reviews.apache.org/r/10231/
This addresses bug MESOS-415.
https://issues.apache.org/jira/browse/MESOS-415
Diffs (updated)
-----
src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
src/tests/slave_recovery_tests.cpp d0ff9b73e06e89a5409f038be2766333e0a0689e
src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
src/tests/utils.hpp 19b285b42dbdcf712511ab89b259b4d43dad3dfb
src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
third_party/libprocess/src/tests/process_tests.cpp 53ade66c9d2dad8ffed2d322665291566acb4c84
Diff: https://reviews.apache.org/r/10241/diff/
Testing
-------
make check
Thanks,
Jiang Yan Xu
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On April 5, 2013, 7:38 p.m., Ben Mahler wrote:
> > src/examples/balloon_executor.cpp, line 24
> > <https://reviews.apache.org/r/10241/diff/1/?file=277220#file277220line24>
> >
> > In all of these removed includes, how did you check whether sleep() was the only call used from unistd.h?
The tests ran successful. Is this sufficient?
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18729
-----------------------------------------------------------
On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Replaced sleep() and usleep() calls in the codebase with
os::sleep();
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10241/#review18729
-----------------------------------------------------------
src/examples/balloon_executor.cpp
<https://reviews.apache.org/r/10241/#comment39149>
In all of these removed includes, how did you check whether sleep() was the only call used from unistd.h?
- Ben Mahler
On April 2, 2013, 10:55 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10241/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> This is the part 2.
> Part 1: https://reviews.apache.org/r/10231/
>
>
> This addresses bug MESOS-415.
> https://issues.apache.org/jira/browse/MESOS-415
>
>
> Diffs
> -----
>
> src/examples/balloon_executor.cpp 6d0d0f99310626978c526ff5eb0778c2bf84587b
> src/examples/long_lived_executor.cpp 3b4a6867ed1a64571edbc606aeec3b3271b05fb9
> src/examples/test_executor.cpp f06dbb30d5f178d2cce274f1ac79763b1db54721
> src/exec/exec.cpp 3d6d712c9577a7b95646e3ca49a7d8bfe47716fd
> src/launcher/executor.cpp 9e0377fba4257fc5579b645c175bc6f0b565fc66
> src/log/log.cpp 852ad119e4f36ad1fd56555af27e440066e9f294
> src/tests/allocator_tests.cpp 04a85815362eaff21027ea7894ee06042fb80dc2
> src/tests/master_tests.cpp c74cb5e05dc068dc75c31fb85e03c71adf4d5ce9
> src/tests/process_spawn.cpp d6996a218763db1f2def48fa0422518b75f47590
> src/tests/slave_recovery_tests.cpp b4276edd09282640fa167cc70d1ab2b1deab3225
> src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e
> src/tests/utils.hpp 32784a79804ecb8758fb9ae6cdb4bb1e87c29252
> src/tests/zookeeper_tests.cpp ac3c39cc9d79dc588eff855c69771ff26902b2ef
> third_party/libprocess/src/process.cpp b4f27077f70468276b9a2f2cbce26036449b5b96
> third_party/libprocess/src/tests/process_tests.cpp f49cabc91257e8cc72a45804a2ddbc28b4e06992
>
> Diff: https://reviews.apache.org/r/10241/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>