You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "vikash7485 (via GitHub)" <gi...@apache.org> on 2026/03/02 17:42:03 UTC

[PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

vikash7485 opened a new pull request, #38347:
URL: https://github.com/apache/superset/pull/38347

   ## Description
   
   Fixes #38187
   
   `dashboard_id` and `slice_id` columns in the `logs` table were always
   `NULL` for every REST API mutation endpoint (POST, PUT, DELETE). This
   made audit logs useless for filtering by dashboard or chart.
   
   ### Root Cause
   
   `log_with_context()` in `utils/log.py` reads IDs from the merged HTTP
   payload:
   ```python
   dashboard_id = to_int(payload.get("dashboard_id"))  # always None
   slice_id     = to_int(payload.get("slice_id"))       # always None
   ```
   
   `collect_request_payload()` only reads `request.form`, `request.args`,
   and `request.json` body. URL path params (e.g. `/api/v1/dashboard/42`)
   are never included, so the IDs were never captured.
   
   ### Fix
   
   Used the existing `allow_extra_payload=True` mechanism — already
   proven working in `DashboardRestApi.get` — to explicitly inject
   `dashboard_id` / `slice_id` into the log payload after each operation.
   
   **11 endpoints fixed across 2 files:**
   
   `superset/dashboards/api.py` (7 endpoints):
   - `post` → `add_extra_log_payload(dashboard_id=new_model.id)`
   - `put` → `add_extra_log_payload(dashboard_id=changed_model.id)`
   - `put_filters` → `add_extra_log_payload(dashboard_id=pk)`
   - `put_chart_customizations` → `add_extra_log_payload(dashboard_id=pk)`
   - `put_colors` → `add_extra_log_payload(dashboard_id=pk)`
   - `delete` → `add_extra_log_payload(dashboard_id=pk)` called **before**
     `DeleteDashboardCommand.run()` so the ID is captured before the row
     is gone
   - `bulk_delete` → `add_extra_log_payload(dashboard_ids=item_ids)` stores
     the list in the `json` column (cannot fit multiple IDs in a single
     integer column — this is intentional)
   
   `superset/charts/api.py` (4 endpoints):
   - `post` → `add_extra_log_payload(slice_id=new_model.id)`
   - `put` → `add_extra_log_payload(slice_id=changed_model.id)`
   - `delete` → `add_extra_log_payload(slice_id=pk)` called before deletion
   - `bulk_delete` → `add_extra_log_payload(slice_ids=item_ids)`
   
   Also added missing `Callable` to the `from typing import` line in
   `charts/api.py`.
   
   ### Testing
   
   **Unit tests** — `tests/integration_tests/event_logger_tests.py`
   
   Added `TestMutationEndpointAuditIds` with 6 regression tests that mock
   `DBEventLogger.log` and assert the correct ID is passed as a kwarg:
   
   | Test | Asserts |
   |---|---|
   | `test_dashboard_put_logs_dashboard_id` | `dashboard_id == 42` |
   | `test_dashboard_delete_logs_dashboard_id` | `dashboard_id == 42` |
   | `test_dashboard_post_logs_dashboard_id` | `dashboard_id == 42` |
   | `test_chart_put_logs_slice_id` | `slice_id == 42` |
   | `test_chart_delete_logs_slice_id` | `slice_id == 42` |
   | `test_chart_post_logs_slice_id` | `slice_id == 42` |
   
   **Integration tests** — `tests/integration_tests/dashboards/api_tests.py`
   and `tests/integration_tests/charts/api_tests.py`
   
   Added DB-level assertions that query the `Log` model directly after
   each mutation and confirm the ID column is non-NULL:
   
   - `test_update_dashboard` → asserts `log.dashboard_id == dashboard_id`
   - `test_delete_dashboard` → asserts `log.dashboard_id == dashboard_id`
   - `test_update_chart` → asserts `log.slice_id == chart_id`
   - `test_delete_chart` → asserts `log.slice_id == chart_id`
   
   **SQL verification query (run after deployment):**
   ```sql
   SELECT id, action, dashboard_id, slice_id, dttm
   FROM logs
   ORDER BY dttm DESC
   LIMIT 20;
   ```
   After this fix, `dashboard_id` will be non-NULL for all
   `DashboardRestApi.*` actions and `slice_id` will be non-NULL for all
   `ChartRestApi.*` actions.
   
   ### Checklist
   
   - [x] Added unit tests
   - [x] Added integration tests with DB-level assertions
   - [x] Tested `delete` captures ID before row deletion
   - [x] `bulk_delete` stores ID list in `json` column (documented above)
   - [x] `Callable` import fix in `charts/api.py`
   - [x] AST syntax check passed on all changed files
   - [ ] Full test suite run pending (requires Flask-capable environment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3985900516

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3992661623

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-5787645870

   Heya @vikash7485, brought this forward on a fresh PR at https://github.com/apache/superset/pull/44553 (you're credited as co-author on the commit). Ended up deriving the id inside `log_this_with_context` instead of per-endpoint, but your create-path plumbing carried over. Thanks for the groundwork!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-5024821438

   @vikash7485 would you like me to push some commits here and try to get it across the finish line?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3999570061

   should we still be using ids or should we be moving to uuids for identification?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #38347:
URL: https://github.com/apache/superset/pull/38347#discussion_r2873949773


##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -321,6 +321,16 @@ def test_delete_chart(self):
         model = db.session.query(Slice).get(chart_id)
         assert model is None
 
+        # Verify audit log
+        log = (
+            db.session.query(Log)
+            .filter_by(action="delete", slice_id=chart_id)

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Mismatched audit log action assertion</b></div>
   <div id="fix">
   
   The test assertion checks for action="delete", but the @event_logger.log_this_with_context decorator on the delete method sets action to "ChartRestApi.delete" via the lambda. This mismatch will cause the assertion to fail. Either update the test to expect "ChartRestApi.delete" or change the decorator's action to "delete" for consistency with other tests.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ```
    --- superset/charts/api.py
    +++ superset/charts/api.py
    @@ -473,7 +473,7 @@
         @event_logger.log_this_with_context(
    -        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.delete",
    +        action="delete",
             log_to_statsd=False,
             allow_extra_payload=True,
         )
   ```
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #5af5a8</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



##########
tests/integration_tests/charts/api_tests.py:
##########
@@ -712,6 +722,17 @@ def test_update_chart(self):
         assert model.certified_by == "Mario Rossi"
         assert model.certification_details == "Edited certification"
         assert model.id in [slice.id for slice in related_dashboard.slices]
+
+        # Verify audit log
+        log = (
+            db.session.query(Log)
+            .filter_by(action="put", slice_id=chart_id)

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Mismatched audit log action assertion</b></div>
   <div id="fix">
   
   Similar to the delete test, the put test assertion checks for action="put", but the logging decorator sets action to "ChartRestApi.put". This will cause the test to fail. Update the decorator's action to "put" for consistency.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ```
    --- superset/charts/api.py
    +++ superset/charts/api.py
    @@ -389,7 +389,7 @@
         @event_logger.log_this_with_context(
    -        action=lambda self, *args, **kwargs: f"{self.__class__.__name__}.put",
    +        action="put",
             log_to_statsd=False,
             allow_extra_payload=True,
         )
   ```
   
   </div>
   </details>
   
   
   
   </div>
   
   
   
   
   <small><i>Code Review Run #5af5a8</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-4792684838

   @vikash7485 I can rebase this past the conflicts in `charts/api.py` and `dashboards/api.py` if you'd like me to... just say the word. 
   
   The other comments stand, and we'd love to see this become mergeable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-4747830563

   @vikash7485 this needs a rebase on current `master`, as both `charts/api.py` and `dashboards/api.py` have changed quite a bit since you branched.
   
   Also, the `TestMutationEndpointAuditIds` tests wrap a local `endpoint` fn rather than hitting the real `post`/`bulk_delete` routes, so they're really re-testing the existing `add_extra_log_payload` plumbing. Your DB-level assertions in the api_tests cover put/delete nicely - could the create/bulk paths get the same treatment so the regression is properly pinned down?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3999579896

   > should we still be using ids or should we be moving to uuids for identification?
   
   <img src="https://media2.giphy.com/media/v1.Y2lkPWJkM2VhNTdlM2VvdTd6MWRzcDJjdTVsN2lhbXA1bjk5em5zNDFzNHU4NjlpMDJ0NSZlcD12MV9naWZzX3NlYXJjaCZjdD1n/zbzNUbpFnlw8E/giphy.gif"/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #38347:
URL: https://github.com/apache/superset/pull/38347#discussion_r2885563907


##########
superset/dashboards/api.py:
##########
@@ -729,6 +733,7 @@ def post(self) -> Response:
             return self.response_400(message=error.messages)
         try:
             new_model = CreateDashboardCommand(item).run()
+            add_extra_log_payload(dashboard_id=new_model.id)
             return self.response(201, id=new_model.id, result=item)

Review Comment:
   Audit-log ID population is now added for `DashboardRestApi.post`, but there doesn’t appear to be an integration test that asserts the persisted `Log.dashboard_id` is set for the create flow (similar to the new update/delete assertions). Adding a DB-level assertion after a dashboard create would help prevent regressions specifically in the REST API path.



##########
tests/integration_tests/event_logger_tests.py:
##########
@@ -254,3 +254,117 @@ def test_func(arg1, add_extra_log_payload, karg1=1):
                 }
             ]
             assert payload["duration_ms"] >= 100
+
+
+class TestMutationEndpointAuditIds(unittest.TestCase):
+    """
+    Regression tests for GitHub issue #38187.
+
+    Verifies that dashboard_id and slice_id are populated in the audit log
+    when REST API mutation endpoints are called (previously they were NULL).
+    """
+
+    # ------------------------------------------------------------------ #
+    # Helper: build a log_this_with_context wrapper with allow_extra_payload
+    # ------------------------------------------------------------------ #
+    def _make_wrapped(self, logger: DBEventLogger, action: str, id_kwarg: str):
+        """
+        Return a function wrapped with log_this_with_context(allow_extra_payload=True)
+        that calls add_extra_log_payload(**{id_kwarg: 42}) — simulating the pattern
+        used by the fixed mutation endpoints.
+        """
+
+        @logger.log_this_with_context(
+            action=action,
+            log_to_statsd=False,
+            allow_extra_payload=True,
+        )
+        def endpoint(add_extra_log_payload=lambda **kw: None):
+            add_extra_log_payload(**{id_kwarg: 42})
+            return "ok"
+
+        return endpoint
+
+    # ------------------------------------------------------------------ #
+    # DashboardRestApi tests
+    # ------------------------------------------------------------------ #
+
+    @patch.object(DBEventLogger, "log")
+    def test_dashboard_put_logs_dashboard_id(self, mock_log):
+        """DashboardRestApi.put must populate dashboard_id in log."""
+        logger = DBEventLogger()
+        endpoint = self._make_wrapped(logger, "DashboardRestApi.put", "dashboard_id")
+
+        with app.test_request_context("/api/v1/dashboard/42"):
+            endpoint()  # pylint: disable=no-value-for-parameter
+
+        assert mock_log.called
+        assert mock_log.call_args[1]["dashboard_id"] == 42
+

Review Comment:
   The new `TestMutationEndpointAuditIds` tests don’t actually exercise the DashboardRestApi/ChartRestApi mutation endpoints (they wrap a local `endpoint` function instead). As written, they largely re-test the existing `test_log_this_with_context_and_extra_payload` behavior rather than verifying the new API changes. Consider either calling the real API endpoints here (or adjusting the PR description) so these tests directly validate the regression in #38187.



##########
superset/charts/api.py:
##########
@@ -363,6 +367,7 @@ def post(self) -> Response:
             return self.response_400(message=error.messages)
         try:
             new_model = CreateChartCommand(item).run()
+            add_extra_log_payload(slice_id=new_model.id)
             return self.response(201, id=new_model.id, result=item)
         except DashboardsForbiddenError as ex:

Review Comment:
   Audit-log ID population is now added for `ChartRestApi.post`, but there doesn’t seem to be an integration test that verifies the `logs.slice_id` column is set after creating a chart (parallel to the new update/delete assertions). Adding a DB-level assertion on the latest `Log` row for `ChartRestApi.post` would make this regression-proof.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3999722215

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38347?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 64.91%. Comparing base ([`1025e37`](https://app.codecov.io/gh/apache/superset/commit/1025e3729b868907a8be2ac76be95ff6138b0a9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7dfad30`](https://app.codecov.io/gh/apache/superset/commit/7dfad3064503598c6f3b778f8cb1a370e6b73253?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 37 commits behind head on master.
   
   :x: Your project check has failed because the head coverage (96.03%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #38347      +/-   ##
   ==========================================
   + Coverage   64.27%   64.91%   +0.64%     
   ==========================================
     Files        1810     2483     +673     
     Lines       71500   123359   +51859     
     Branches    22763    28636    +5873     
   ==========================================
   + Hits        45954    80082   +34128     
   - Misses      25546    41868   +16322     
   - Partials        0     1409    +1409     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.06% <100.00%> (?)` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.14% <100.00%> (?)` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.12% <52.17%> (?)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.79% <100.00%> (?)` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/38347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38347?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints #38187 [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-3992315145

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 7dfad3064503598c6f3b778f8cb1a370e6b73253 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69a710a76cef8f00084c683e |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-38347--superset-docs-preview.netlify.app](https://deploy-preview-38347--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTM4MzQ3LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.tTJrrsVjXbo-EorcRnnpQ1-1skbd0do9XeRZZykF_X0)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-38347--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "vikash7485 (via GitHub)" <gi...@apache.org>.
vikash7485 closed pull request #38347: fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints 
URL: https://github.com/apache/superset/pull/38347


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(api): populate dashboard_id and slice_id in audit logs for mutation endpoints [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38347:
URL: https://github.com/apache/superset/pull/38347#issuecomment-5765932471

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org