You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/30 23:59:46 UTC
[GitHub] [arrow-ballista] yahoNanJing opened a new pull request, #181: Update task status to the its job curator scheduler
yahoNanJing opened a new pull request, #181:
URL: https://github.com/apache/arrow-ballista/pull/181
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #179.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1232294438
Hi @thinkharderdev, @andygrove, @avantgardnerio, could you help have a review?
Later I will propose another PR for dealing with multiple schedulers registration and heartbeating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1233586534
@alamb might be able to help with reviews as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1232378525
I will review in more depth tomorrow, but my main question with this series of PRs is: does Ballista remain releasable/functional as they are merged? Or do they all need to land before the new single-curator architecture is ready for action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234522307
It is very exciting to see the acceleration of people engaging and contributing to the Ballista project ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234358278
Hi @andygrove, just rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb merged pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
alamb merged PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234249520
@yahoNanJing This one needs a rebase now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234522822
Since this has two approvals, merging it in. I will also attempt to get some more committer bandwidth for Ballista. Stay tuned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1232419217
Hi @avantgardnerio, thanks for your comment. Yes, this PR will not break the ballista function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234308698
> I am happy to help with logistical support but I just don't want you all to labor under bad expectations
I should also point out that we encourage everyone to help with reviews (not just committers) -- I think especially as @yahoNanJing and the rest of the Ebay team become more experts in Ballista you are likely well positioned to take on a leading role with reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234259557
> @alamb might be able to help with reviews as well.
FYI to avoid miscommunication, I am unlikely to have time to review ballista PRs -- my open source time is already (more than) occuplied with sqlparser, arrow-rs and datafusion ;)
I am happy to help with logistical support but I just don't want you all to labor under bad expectations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] avantgardnerio commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234409696
> Hi @alamb, we are willing to lead the ballista to be a better product for production usage. Recently we are working on several things, like performance enhancement, error handling, etc.
>
> Thanks @thinkharderdev and @avantgardnerio for engaging reviewing on bunch of PRs recently from us. It would be much better to have more people from different background engaging on ballista things, like issue proposing, PR reviewing, etc smile
We're very happy to @yahoNanJing . I appologize for not yet having enough context on some of these more architectural PRs at this point in time, but I've requested our (S&T) engineers focus more on Ballista than DataFusion to compensate for the disproportionate amount of reviewers on the two projects.
Our company is committed to Ballista, we have 3.5 engineers on it at present, and I'm sure that number will go up. As it does and we gain experience, we look forward to working with you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] yahoNanJing commented on pull request #181: Update task status to the its job curator scheduler
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #181:
URL: https://github.com/apache/arrow-ballista/pull/181#issuecomment-1234366320
Hi @alamb, we are willing to lead the ballista to be a better product for production usage. Recently we are working on several things, like performance enhancement, error handling, etc.
Thanks @thinkharderdev and @avantgardnerio for engaging reviewing on bunch of PRs recently from us. It would be much better to have more people from different background engaging on ballista things, like issue proposing, PR reviewing, etc 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org