You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nihal Jain (JIRA)" <ji...@apache.org> on 2019/01/31 08:58:00 UTC
[jira] [Commented] (HBASE-21243) Correct java-doc for the method
RpcServer.getRemoteAddress()
[ https://issues.apache.org/jira/browse/HBASE-21243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757029#comment-16757029 ]
Nihal Jain commented on HBASE-21243:
------------------------------------
Ping [~tianjingyun] Simple patch. Please review.
> Correct java-doc for the method RpcServer.getRemoteAddress()
> ------------------------------------------------------------
>
> Key: HBASE-21243
> URL: https://issues.apache.org/jira/browse/HBASE-21243
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.0.0
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Trivial
> Labels: beginner, beginners, documentaion
> Fix For: 3.0.0
>
> Attachments: HBASE-21243.master.001.patch, HBASE-21243.master.002.patch
>
>
> Correct the java-doc for the method {{RpcServer.getRemoteAddress()}}.
> Currently it look like as below:
> {code:java}
> /**
> * @return Address of remote client if a request is ongoing, else null
> */
> public static Optional<InetAddress> getRemoteAddress() {
> return getCurrentCall().map(RpcCall::getRemoteAddress);
> }
> {code}
> Contrary to the doc the method will never return null. Rather it may return an empty Optional.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)